Review main Merged

65504[TASK] DatabaseRecordList: Drop property `HTMLcode`

Daniel Windloff CR +2 V +2 Normal +18 −36 updated 08/30/20, 14:55

Commit message

The property `HTMLcode` was only used to collect the output for the
tables in `generateList()`. Therefore, `generateList()` returns the
collected output and the property `HTMLcode` has been removed.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 811

  1. Daniel Windloff uploaded patch set 1 08/30/20, 08:10

  2. TYPO3com voted on patch set 1 V -1 08/30/20, 08:22 Completed build in 11m 28s on Sun, 30 Aug, 08:22 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5048

  3. Daniel Windloff uploaded patch set 2 08/30/20, 08:34

  4. TYPO3com voted on patch set 2 V +1 08/30/20, 08:46 Completed build in 11m 47s on Sun, 30 Aug, 08:46 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5050

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 08/30/20, 10:44

  6. Oliver Klee commented on patch set 2 CR -1 08/30/20, 10:46

    DatabaseRecordList.php:2745

    We need a string return type declaration now (or at least a PHPDoc annotation).
  7. Christian Kuhn uploaded patch set 3 08/30/20, 14:23

  8. Christian Kuhn commented on patch set 3 V +1 CR +1 08/30/20, 14:24

    DatabaseRecordList.php:2745 Reply

    Done
  9. TYPO3com voted on patch set 3 V +1 08/30/20, 14:36 Completed build in 12m 12s on Sun, 30 Aug, 02:36 PM Test Summary: 73098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5055

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/30/20, 14:55

  11. Anja Leichsenring merged patch set 4 08/30/20, 14:55