65505[TASK] DatabaseRecordList: Streamline translation and localization
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1319
-
Daniel Windloff uploaded patch set 1 08/31/20, 06:57
-
Daniel Windloff uploaded patch set 2 08/31/20, 07:01
-
TYPO3com voted on patch set 1 V -1 08/31/20, 07:01 Completed build in 31s on Mon, 31 Aug, 07:01 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5070
-
TYPO3com voted on patch set 2 V +1 08/31/20, 07:13 Completed build in 12m 30s on Mon, 31 Aug, 07:13 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5071
-
Andreas Kienast commented on patch set 2 CR -1 09/05/20, 09:20
DatabaseRecordList.php:2179Shouldn't this be array_filter as well?DatabaseRecordList.php:2179You may use `static function` here.DatabaseRecordList.php:2179missing return here for the "else" caseDatabaseRecordList.php:2180return $languageUid > 0 -
Daniel Windloff uploaded patch set 3 09/05/20, 09:45
-
Daniel Windloff commented on patch set 3 09/05/20, 09:47
DatabaseRecordList.php:2171ReplyDoneDatabaseRecordList.php:2179ReplyDoneDatabaseRecordList.php:2179ReplyDoneDatabaseRecordList.php:2179Reply UnresolvedI'd like to collect the language uids. So array_map should be there.DatabaseRecordList.php:2180ReplyDone -
TYPO3com voted on patch set 3 V -1 09/05/20, 10:00 Completed build in 14m 45s on Sat, 5 Sep, 10:00 AM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5262
-
TYPO3com voted on patch set 3 V +1 09/05/20, 10:26 Completed build in 16m 10s on Sat, 5 Sep, 10:26 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5266
-
Daniel Windloff uploaded patch set 4 09/05/20, 14:58
-
TYPO3com voted on patch set 4 V +1 09/05/20, 15:09 Completed build in 11m 18s on Sat, 5 Sep, 03:09 PM Test Summary: 73212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5283
-
Christian Kuhn voted on patch set 4 V +1 CR +1 09/08/20, 10:33
-
Anja Leichsenring updated the commit message in patch set 5 09/08/20, 16:22
-
TYPO3com voted on patch set 5 V +1 09/08/20, 16:34 Completed build in 12m 22s on Tue, 8 Sep, 04:34 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5375
-
Anja Leichsenring commented on patch set 5 V +1 CR +1 09/08/20, 16:35
tested with a non priviledged user, hope I did not miss anything. -
Christian Kuhn voted on patch set 5 V +2 CR +2 09/08/20, 17:53
-
Christian Kuhn merged patch set 6 09/08/20, 17:53
-
Oli Bartsch commented on patch set 6 09/29/20, 18:01
Post -1 Leads to multiple regressions. Will create a issue. -
Oli Bartsch commented on patch set 6 09/29/20, 18:52
DatabaseRecordList.php:2171