Review main Merged

65506[TASK] Default workspaces_perms=0 for new be_users

Christian Kuhn CR +2 V +2 Easy +12 −0 updated 09/01/20, 11:38

Commit message

Field workspace_perms=1 for backend users or groups enables
editing of the live workspace.
When ext:workspaces is loaded, we can assume the extension
is actively used in the instance. If so, many backend users
most likely should NOT have live edit access and the flag
is probably given to only a small group of editors by assigning
a 'chief editor' group or similar that carries the flag.
The patch sets workspace_perms for new backend users by
default to 0 when ext:workspaces is loaded, making it more
unlikely admins accidentially give live edit access to users.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Christian Kuhn uploaded patch set 1 08/31/20, 07:43

  2. Christian Kuhn updated the commit message in patch set 2 08/31/20, 07:47

  3. TYPO3com voted on patch set 1 V -1 08/31/20, 07:59 Completed build in 15m 38s on Mon, 31 Aug, 07:59 AM Test Summary: 2 of 73632 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5072

  4. TYPO3com voted on patch set 2 V -1 08/31/20, 08:05 Completed build in 17m 48s on Mon, 31 Aug, 08:05 AM Test Summary: 72816 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5073

  5. TYPO3com voted on patch set 2 V +1 08/31/20, 10:35 Completed build in 3h 05m 08s on Mon, 31 Aug, 10:35 AM Test Summary: 73145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5073

  6. Jörg Bösche commented on patch set 2 08/31/20, 14:32

    I'm just assuming the situation that I'm upgrading from 10 LTS to 11 and suddenly the editors call me ... they can no longer edit live. A RST file would be really cool.
  7. Christian Kuhn commented on patch set 2 08/31/20, 14:39

    Consider this change is only for newly created backend users. There is no change for existing users. This change is just a better default for admin users that no longer need to turn-off the flag when creating new users when using workspaces.
  8. Benni Mack commented on patch set 2 V +1 CR +1 09/01/20, 06:47

    I personally don't agree with this change. This option should actually be made consistent, and on top: A list of all workspaces a user has access to (in what stage) would be useful. Same goes for live workspace.
  9. Christian Kuhn commented on patch set 2 09/01/20, 06:55

    Agreed, Benni. The workspace related permission system clearly needs an overhaul. This patch does not help much and is just a convenience measure for backend admins for now.
  10. Oli Bartsch uploaded patch set 3 09/01/20, 10:04

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 09/01/20, 10:07

  12. TYPO3com voted on patch set 3 V +1 09/01/20, 10:16 Completed build in 11m 42s on Tue, 1 Sep, 10:16 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5098

  13. Jörg Bösche voted on patch set 3 CR +1 09/01/20, 10:17

  14. Benni Mack voted on patch set 3 V +2 CR +2 09/01/20, 11:38

  15. Benni Mack merged patch set 4 09/01/20, 11:38