Review main Merged

65508[BUGFIX] Correctly call BackendUtility::selectVersionsOfRecord

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 08/31/20, 12:03

Commit message

Issue #69135 fixed issue #60249, but introduced an invalid call
to `BackendUtility::selectVersionsOfRecord`. The scope was to
handle all versions in all workspaces (`$workspace=null`).
As a result, without patch, command 'cleanup:versions' reports
too many unused placeholder rows and the action command
'cleanup:versions --action=unused_placeholders' deletes too many.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/31/20, 11:15

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 08/31/20, 11:17

  3. TYPO3com voted on patch set 1 V +1 08/31/20, 11:27 Completed build in 11m 30s on Mon, 31 Aug, 11:27 AM Test Summary: 73144 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5082

  4. Oliver Hader commented on patch set 1 CR +1 08/31/20, 11:49

    Thx for finishing this change request
  5. Benni Mack voted on patch set 1 V +2 CR +2 08/31/20, 12:03

  6. Benni Mack merged patch set 2 08/31/20, 12:03