Review main Merged

65510[BUGFIX] Update ref-index when deleting new workspace relations

Christian Kuhn CR +2 V +2 Hard +131 −172 updated 09/07/20, 21:01

Commit message

Adding an image to a workspace content element adds two
sys_refindex entries: One for the sys_file_reference
t3ver_state=-1 and one for the t3ver_state=1 record.

Deleting the image reference again in workspaces only sets
one of the two to deleted in sys_refindex, leading to orphan
sys_refindex entries.

The patch fixes this by adding a 'redo refindex' call at the
appropriate place.

There are more issues when 'discard changes' is used together with
multi-level relations (tt_content->hotel->offer->price): Discard
does not properly cascade in those cases, yet. The patch touches
this as a side-effect and does not improve the situation. The .csv
files are marked with @todo accordingly and will be fixed with further
patches. Those scenarios are more seldom than a broken sys_refindex
for FAL images which is the primary goal of this patch.

Analyzing the test scenarios, the patch actually removes various
rows from sys_refindex where the left part of the relation is set
to deleted. This is correct and wanted: In the end we don't want
sys_refindex to contain reference to deleted rows at all. This
strategy will be further followed with other patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 41

Show 21 more files

Review log 1018

  1. Christian Kuhn uploaded patch set 1 08/31/20, 15:08

  2. Christian Kuhn updated the commit message in patch set 2 08/31/20, 15:09

  3. TYPO3com voted on patch set 1 V +1 08/31/20, 15:20 Completed build in 12m 04s on Mon, 31 Aug, 03:20 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5090

  4. TYPO3com voted on patch set 2 V +1 08/31/20, 15:26 Completed build in 15m 39s on Mon, 31 Aug, 03:26 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5091

  5. Benni Mack updated the commit message in patch set 3 09/07/20, 09:14

  6. Benni Mack voted on patch set 3 V +1 CR +1 09/07/20, 09:14

  7. TYPO3com voted on patch set 3 V -1 09/07/20, 09:25 Completed build in 10m 59s on Mon, 7 Sep, 09:25 AM Test Summary: 102 of 73712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5315

  8. Christian Kuhn updated the commit message in patch set 4 09/07/20, 14:48

  9. TYPO3com voted on patch set 4 V -1 09/07/20, 14:59 Completed build in 10m 45s on Mon, 7 Sep, 02:59 PM Test Summary: 120 of 73712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5331

  10. Christian Kuhn uploaded patch set 5 09/07/20, 18:38

  11. Christian Kuhn updated the commit message in patch set 6 09/07/20, 18:41

  12. TYPO3com voted on patch set 5 V -1 09/07/20, 18:54 Completed build in 15m 45s on Mon, 7 Sep, 06:54 PM Test Summary: 57 of 73712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5345

  13. TYPO3com voted on patch set 6 V -1 09/07/20, 18:59 Completed build in 14m 59s on Mon, 7 Sep, 06:59 PM Test Summary: 58 of 73712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5346

  14. TYPO3com commented on patch set 6 09/07/20, 19:28 Completed build in 59m 20s on Mon, 7 Sep, 07:28 PM Test Summary: 57 of 73712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5346

  15. Christian Kuhn uploaded patch set 7 09/07/20, 20:17

  16. TYPO3com voted on patch set 7 V +1 09/07/20, 20:34 Completed build in 16m 31s on Mon, 7 Sep, 08:34 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5351

  17. Benni Mack commented on patch set 7 V +2 CR +2 09/07/20, 21:01

    merging this one as workspace-only change.
  18. Benni Mack merged patch set 8 09/07/20, 21:01