Review main Merged

65511[DOCS] Avoid use of TYPO3_MODE checks in ext_localconf.php

Oli Bartsch CR +2 V +2 Easy +11 −13 updated 09/01/20, 14:10

Commit message

As it's highly discouraged to check for global constants in
ext_localconf.php due to limited caching the example code
is updated to not propose this check anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Björn Jacob +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Björn Jacob +1
    • Christian Kuhn +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 09/01/20, 10:25

  2. TYPO3com voted on patch set 1 V +1 09/01/20, 10:36 Completed build in 11m 34s on Tue, 1 Sep, 10:36 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5100

  3. Jörg Bösche voted on patch set 1 V +1 CR +1 09/01/20, 11:16

  4. Oliver Klee voted on patch set 1 CR +1 09/01/20, 12:08

  5. Björn Jacob voted on patch set 1 V +1 CR +1 09/01/20, 13:49

  6. Christian Kuhn voted on patch set 1 V +1 CR +1 09/01/20, 14:05

  7. Benni Mack voted on patch set 1 V +2 CR +2 09/01/20, 14:10

  8. Benni Mack merged patch set 2 09/01/20, 14:10