Review main Merged

65512[TASK] Drop extbase from workspace module

Christian Kuhn CR +2 V +2 Normal +76 −70 updated 09/02/20, 08:45

Commit message

The main workspace module ReviewController uses the extbase
ActionController. There is little reason to do so: There is
only one action, no injection is used, no other extbase magic.
The patch drops extbase usage from ext:workspaces and keeps the
module name so permission settings need no change.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 09/01/20, 12:05

  2. TYPO3com voted on patch set 1 V +1 09/01/20, 12:15 Completed build in 10m 21s on Tue, 1 Sep, 12:15 PM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5105

  3. Wouter Wolters voted on patch set 1 CR +1 09/01/20, 21:34

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 09/01/20, 22:34

  5. Benni Mack voted on patch set 1 V +2 CR +2 09/02/20, 08:45

  6. Benni Mack merged patch set 2 09/02/20, 08:45