Review main Merged

65514[TASK] Execute frontend functional tests in sub request

Christian Kuhn CR +2 V +2 Expert +753 −737 updated 12/01/20, 14:09

Commit message

Constants TYPO3_MODE and TYPO3_REQUESTTYPE are unused
in core, and we have a new helper method in
typo3/testing-framework to execute sub requests.

The patch switches all functional tests that execute
frontend requests to use a sub request instead of
handling standalone PHP processes.

This patch is quite a milestone: It is the proof that
TYPO3 framework state can be managed well enough to
execute multiple TYPO3 application requests in one process.

As a happy little side effect, the overall performance
of the functional tests is increased by roughly 20
percent. This is quite a bit when considering the fact
that most execution time is consumed by setting up
all the database tables.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 3

Files 55

Show 35 more files

Review log 2953

Show 1528 earlier messages
  1. Christian Kuhn uploaded patch set 1 09/01/20, 14:13

  2. TYPO3com voted on patch set 1 V -1 09/01/20, 14:18 Completed build in 29s on Tue, 1 Sep, 02:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5110

  3. Christian Kuhn commented on patch set 1 CR -1 09/01/20, 15:55

    just wip, we will probably solve differently.
  4. Benjamin Franzke uploaded patch set 2 09/01/20, 16:31

  5. TYPO3com voted on patch set 2 V -1 09/01/20, 16:35 Completed build in 04m 18s on Tue, 1 Sep, 04:35 PM Test Summary: 9 of 62749 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5114

  6. Benjamin Franzke uploaded patch set 3 09/01/20, 16:52

  7. TYPO3com voted on patch set 3 V -1 09/01/20, 17:03 Completed build in 10m 56s on Tue, 1 Sep, 05:03 PM Test Summary: 633 of 73554 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5115

  8. Benjamin Franzke uploaded patch set 4 09/01/20, 17:29

  9. TYPO3com voted on patch set 4 V -1 09/01/20, 17:40 Completed build in 11m 34s on Tue, 1 Sep, 05:40 PM Test Summary: 12 of 73649 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5116

  10. Benjamin Franzke uploaded patch set 5 09/01/20, 18:53

  11. TYPO3com voted on patch set 5 V +1 09/01/20, 19:05 Completed build in 11m 37s on Tue, 1 Sep, 07:05 PM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5117

  12. Christian Kuhn uploaded patch set 6 11/16/20, 15:44

  13. TYPO3com voted on patch set 6 V -1 11/16/20, 15:55 Completed build in 11m 34s on Mon, 16 Nov, 03:55 PM Test Summary: 6 of 74108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7360

  14. Christian Kuhn uploaded patch set 7 11/16/20, 16:17

  15. TYPO3com voted on patch set 7 V +1 11/16/20, 16:28 Completed build in 11m 01s on Mon, 16 Nov, 04:28 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7361

  16. Christian Kuhn uploaded patch set 8 11/18/20, 16:44

  17. Christian Kuhn uploaded patch set 9 11/18/20, 16:47

  18. TYPO3com voted on patch set 8 V -1 11/18/20, 16:56 Completed build in 12m 44s on Wed, 18 Nov, 04:56 PM Test Summary: 4749 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7402

  19. TYPO3com voted on patch set 9 V -1 11/18/20, 17:04 Completed build in 12m 32s on Wed, 18 Nov, 05:04 PM Test Summary: 4749 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7404

  20. Christian Kuhn uploaded patch set 10 11/18/20, 17:15

  21. TYPO3com voted on patch set 10 V -1 11/18/20, 17:27 Completed build in 11m 49s on Wed, 18 Nov, 05:27 PM Test Summary: 3 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7406

  22. Christian Kuhn uploaded patch set 11 11/18/20, 17:29

  23. TYPO3com voted on patch set 11 V +1 11/18/20, 17:40 Completed build in 11m 19s on Wed, 18 Nov, 05:40 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7407

  24. Christian Kuhn uploaded patch set 12 11/18/20, 18:48

  25. TYPO3com voted on patch set 12 V +1 11/18/20, 18:58 Completed build in 10m 07s on Wed, 18 Nov, 06:58 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7408

  26. Christian Kuhn uploaded patch set 13 11/18/20, 19:07

  27. Christian Kuhn uploaded patch set 14 11/18/20, 19:14

  28. TYPO3com voted on patch set 13 V +1 11/18/20, 19:17 Completed build in 10m 39s on Wed, 18 Nov, 07:17 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7409

  1. TYPO3com voted on patch set 14 V +1 11/18/20, 19:25 Completed build in 10m 08s on Wed, 18 Nov, 07:24 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7410

  2. Christian Kuhn uploaded patch set 15 11/19/20, 09:41

  3. TYPO3com voted on patch set 15 V +1 11/19/20, 09:55 Completed build in 13m 29s on Thu, 19 Nov, 09:55 AM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7415

  4. Christian Kuhn uploaded patch set 16 11/19/20, 10:09

  5. TYPO3com voted on patch set 16 V +1 11/19/20, 10:24 Completed build in 14m 19s on Thu, 19 Nov, 10:24 AM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7417

  6. Christian Kuhn uploaded patch set 17 11/19/20, 12:03

  7. TYPO3com voted on patch set 17 V +1 11/19/20, 12:22 Completed build in 18m 05s on Thu, 19 Nov, 12:22 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7420

  8. Christian Kuhn uploaded patch set 18 11/24/20, 10:31

  9. TYPO3com voted on patch set 18 V -1 11/24/20, 10:32 Completed build in 31s on Tue, 24 Nov, 10:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7538

  10. Christian Kuhn uploaded patch set 19 11/24/20, 10:33

  11. TYPO3com voted on patch set 19 V +1 11/24/20, 10:43 Completed build in 09m 42s on Tue, 24 Nov, 10:43 AM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7539

  12. Christian Kuhn uploaded patch set 20 12/01/20, 09:16

  13. TYPO3com voted on patch set 20 V -1 12/01/20, 09:17 Completed build in 26s on Tue, 1 Dec, 09:17 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7725

  14. Christian Kuhn uploaded patch set 21 12/01/20, 09:32

  15. TYPO3com voted on patch set 21 V -1 12/01/20, 09:42 Completed build in 10m 14s on Tue, 1 Dec, 09:42 AM Test Summary: 18 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7726

  16. Christian Kuhn uploaded patch set 22 12/01/20, 09:58

  17. TYPO3com voted on patch set 22 V +1 12/01/20, 10:07 Completed build in 09m 04s on Tue, 1 Dec, 10:07 AM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7728

  18. Christian Kuhn uploaded patch set 23 12/01/20, 11:43

  19. TYPO3com voted on patch set 23 V -1 12/01/20, 12:00 Completed build in 10m 44s on Tue, 1 Dec, 11:59 AM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7731

  20. Christian Kuhn uploaded patch set 24 12/01/20, 13:32

  21. TYPO3com voted on patch set 24 V +1 12/01/20, 13:42 Completed build in 09m 22s on Tue, 1 Dec, 01:42 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7735

  22. Oli Bartsch voted on patch set 24 V +1 CR +1 12/01/20, 13:50

  23. Daniel Goerz voted on patch set 24 V +1 CR +1 12/01/20, 14:02

  24. Christian Kuhn voted on patch set 24 V +2 CR +2 12/01/20, 14:05

  25. Christian Kuhn merged patch set 25 12/01/20, 14:09