Review 9.5 Merged

65532[DOCS] Avoid use of TYPO3_MODE checks in ext_localconf.php

Oli Bartsch CR +2 V +2 Easy +11 −13 updated 09/02/20, 08:37

Commit message

As it's highly discouraged to check for global constants in
ext_localconf.php due to limited caching the example code
is updated to not propose this check anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 09/01/20, 16:34

  2. TYPO3com voted on patch set 1 V +1 09/01/20, 16:48 Completed build in 13m 52s on Tue, 1 Sep, 04:48 PM Test Summary: 75145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-768

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 09/01/20, 22:33

  4. Benni Mack voted on patch set 1 V +2 CR +2 09/02/20, 08:37

  5. Benni Mack merged patch set 2 09/02/20, 08:37