Review main Merged

65533[BUGFIX] Add FieldWizard for other language thumbnails

Oli Bartsch CR +2 V +2 Normal +115 −3 updated 09/20/20, 15:59

Commit message

Instead of displaying the JSON value of the `crop` field, which
has no value for editors, the otherLanguageContent wizard is
replaced with a new wizard which renders cropped thumbnails
for other languages by respecting the corresponding cropping
configuration.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1013

  1. Oli Bartsch uploaded patch set 1 09/01/20, 22:34

  2. TYPO3com voted on patch set 1 V +1 09/01/20, 22:47 Completed build in 12m 39s on Tue, 1 Sep, 10:47 PM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5118

  3. Christian Kuhn commented on patch set 1 09/01/20, 22:48

    nice!
  4. Oli Bartsch uploaded patch set 2 09/02/20, 08:29

  5. TYPO3com voted on patch set 2 V +1 09/02/20, 08:40 Completed build in 10m 57s on Wed, 2 Sep, 08:40 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5124

  6. Jörg Bösche voted on patch set 2 CR +1 09/03/20, 12:18

  7. Jörg Bösche commented on patch set 2 09/10/20, 10:20

    I was just testing the patch set and noticed the size of the thumbnails. We should use the same image dimensions (['maxWidth' => '145', 'maxHeight' => '45']) as in the latest patch for InlineRecordContainer. https://review.typo3.org/c/Packages/TYPO3.CMS/+/65278 The pictures from "otherLanguage" don't have to be that big. We should be uniform in the image sizes in the backend. What do you think about it?
  8. Oli Bartsch uploaded patch set 3 09/10/20, 12:33

  9. Oli Bartsch commented on patch set 3 09/10/20, 12:34

    > Patch Set 2: > > I was just testing the patch set and noticed the size of the thumbnails. > We should use the same image dimensions (['maxWidth' => '145', 'maxHeight' => '45']) as in the latest patch for InlineRecordContainer. https://review.typo3.org/c/Packages/TYPO3.CMS/+/65278 > > The pictures from "otherLanguage" don't have to be that big. We should be uniform in the image sizes in the backend. > > What do you think about it? Yes, fine for me. Changed the patch accordingly.
  10. TYPO3com voted on patch set 3 V +1 09/10/20, 12:44 Completed build in 10m 32s on Thu, 10 Sep, 12:44 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5492

  11. Jörg Bösche commented on patch set 3 V +1 CR +1 09/10/20, 12:58

    Thanks :-)
  12. Daniel Goerz voted on patch set 3 V +2 CR +2 09/20/20, 15:59

  13. Daniel Goerz merged patch set 4 09/20/20, 15:59