Review main Merged

65535[BUGFIX] Ensure workspace's new placeholder keeps sorting+pid on moving

Benni Mack CR +2 V +2 Normal +148 −6 updated 09/03/20, 20:41

Commit message

When a newly created record in a workspace is added, two records
are created:

  * t3ver_state=-1 (the versioned record NEW_PLACEHOLDER_VERSION which contains the data)
  * t3ver_state=1 (the placeholder NEW_PLACEHOLDER)

When the record is now moved (= sorting or pid is changed) then
the versioned record was previously not updated sorting or pid values.

This change keeps both records in sync making it easier to have a
consistent setup. This is helpful when working on versioned records
(and not on the pairs = overlays) directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1013

  1. Benni Mack uploaded patch set 1 09/02/20, 10:23

  2. TYPO3com voted on patch set 1 V +1 09/02/20, 10:35 Completed build in 11m 27s on Wed, 2 Sep, 10:35 AM Test Summary: 73176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5130

  3. Benni Mack uploaded patch set 2 09/02/20, 21:31

  4. TYPO3com voted on patch set 2 V +1 09/02/20, 21:49 Completed build in 15m 07s on Wed, 2 Sep, 09:48 PM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5157

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 09/03/20, 07:36

  6. Oliver Hader commented on patch set 2 CR -1 09/03/20, 09:25

    I know there have been controversial discussions - however, in the past the common part of a scenario (e.g. create new page, move it to some other page) were kept in the abstract class - the specific implementations on ActionTest were using them and performing additional tasks (like publish or frontend preview)... Currently the common scenario is spread and duplicated into each ActionTest

    DataHandlerHook.php:420 Unresolved

    I think it would be possible to change the if-blocks... * if (empty($workspaceVersion['uid']) || !$tableSupportsVersioning) → $recordWasMoved = false; * elseif (!$recIsNewVersion) → moveRecord_wsPlaceholders * else → moveRecord_raw (keeping the new placeholders, but not generate additional move placeholders)

    ActionTest.php:434 Unresolved

    `$this->actionService->publishWorkspace(self::VALUE_WorkspaceId);` for publishing the whole workspace - that's the difference between Publish and PublishAll
  7. Oliver Hader commented on patch set 2 09/03/20, 09:26

    ActionTest.php:447 Unresolved

    ... same here of course ...
  8. Benni Mack uploaded patch set 3 09/03/20, 10:44

  9. Benni Mack commented on patch set 3 09/03/20, 10:45

    Thanks for the remarks, Olly. All remarks adapted.
  10. TYPO3com voted on patch set 3 V +1 09/03/20, 10:56 Completed build in 11m 55s on Thu, 3 Sep, 10:56 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5168

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/03/20, 20:17

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 09/03/20, 20:41

  13. Christian Kuhn merged patch set 4 09/03/20, 20:41