65535[BUGFIX] Ensure workspace's new placeholder keeps sorting+pid on moving
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+23 −0
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php1+14 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createPageAndChangePageSorting.csvnew+8 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createPageAndMoveCreatedPage.csvnew+8 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+20 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/createPageAndChangePageSorting.csvnew+7 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/createPageAndMoveCreatedPage.csvnew+7 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/ActionTest.php+22 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createPageAndChangePageSorting.csvnew+7 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createPageAndMoveCreatedPage.csvnew+7 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/ActionTest.php2+25 −0
Review log 1013
-
Benni Mack uploaded patch set 1 09/02/20, 10:23
-
TYPO3com voted on patch set 1 V +1 09/02/20, 10:35 Completed build in 11m 27s on Wed, 2 Sep, 10:35 AM Test Summary: 73176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5130
-
Benni Mack uploaded patch set 2 09/02/20, 21:31
-
TYPO3com voted on patch set 2 V +1 09/02/20, 21:49 Completed build in 15m 07s on Wed, 2 Sep, 09:48 PM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5157
-
Christian Kuhn voted on patch set 2 V +1 CR +1 09/03/20, 07:36
-
Oliver Hader commented on patch set 2 CR -1 09/03/20, 09:25
I know there have been controversial discussions - however, in the past the common part of a scenario (e.g. create new page, move it to some other page) were kept in the abstract class - the specific implementations on ActionTest were using them and performing additional tasks (like publish or frontend preview)... Currently the common scenario is spread and duplicated into each ActionTestDataHandlerHook.php:420UnresolvedI think it would be possible to change the if-blocks... * if (empty($workspaceVersion['uid']) || !$tableSupportsVersioning) → $recordWasMoved = false; * elseif (!$recIsNewVersion) → moveRecord_wsPlaceholders * else → moveRecord_raw (keeping the new placeholders, but not generate additional move placeholders)ActionTest.php:434Unresolved`$this->actionService->publishWorkspace(self::VALUE_WorkspaceId);` for publishing the whole workspace - that's the difference between Publish and PublishAll -
Oliver Hader commented on patch set 2 09/03/20, 09:26
ActionTest.php:447Unresolved... same here of course ... -
Benni Mack uploaded patch set 3 09/03/20, 10:44
-
Benni Mack commented on patch set 3 09/03/20, 10:45
Thanks for the remarks, Olly. All remarks adapted. -
TYPO3com voted on patch set 3 V +1 09/03/20, 10:56 Completed build in 11m 55s on Thu, 3 Sep, 10:56 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5168
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 09/03/20, 20:17
-
Christian Kuhn voted on patch set 3 V +2 CR +2 09/03/20, 20:41
-
Christian Kuhn merged patch set 4 09/03/20, 20:41