Review main Merged

65536[BUGFIX] Apply default values before processing datamap

Oli Bartsch CR +2 V +2 Normal +156 −0 updated 09/04/20, 13:49

Commit message

By creating new records the EditDocumentController did not take the
default values fetched via GET / Post variables into account. This led
to multiple issues when defining columns to be readOnly, disabled or
hideForNonAdmins as the values are then stored in defVals parameter
but never added to the final datamap.

The default values are now being added to the Datahandler prior
to process_datamap call.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Loek Hilgersom +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Loek Hilgersom +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 1217

  1. Oli Bartsch uploaded patch set 1 09/02/20, 10:39

  2. TYPO3com voted on patch set 1 V +1 09/02/20, 10:55 Completed build in 14m 20s on Wed, 2 Sep, 10:55 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5133

  3. Oli Bartsch uploaded patch set 2 09/03/20, 12:24

  4. TYPO3com voted on patch set 2 V +1 09/03/20, 12:36 Completed build in 11m 41s on Thu, 3 Sep, 12:36 PM Test Summary: 73185 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5174

  5. Benni Mack commented on patch set 2 09/03/20, 12:56

    EditDocumentControllerTest.php:73

    could we also add a test where the $_POST variables also contains CType=text ?
  6. Oli Bartsch uploaded patch set 3 09/04/20, 08:26

  7. Oli Bartsch uploaded patch set 4 09/04/20, 08:28

  8. TYPO3com voted on patch set 3 V +1 09/04/20, 08:38 Completed build in 12m 02s on Fri, 4 Sep, 08:38 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5214

  9. Oli Bartsch commented on patch set 4 09/04/20, 08:39

    > Patch Set 2: > > (1 comment)

    EditDocumentControllerTest.php:73 Reply

    Added a new test for this case.
  10. TYPO3com voted on patch set 4 V +1 09/04/20, 08:45 Completed build in 17m 24s on Fri, 4 Sep, 08:45 AM Test Summary: 73205 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5215

  11. Benni Mack updated the commit message in patch set 5 09/04/20, 12:04

  12. Benni Mack voted on patch set 5 V +1 CR +1 09/04/20, 12:04

  13. TYPO3com voted on patch set 5 V +1 09/04/20, 12:16 Completed build in 11m 53s on Fri, 4 Sep, 12:16 PM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5235

  14. Loek Hilgersom commented on patch set 5 V +1 CR +1 09/04/20, 13:39

    Reviewed and tested the issues as reported in forge #92119: - It resolves the problem where colPos is always 0 when adding new content in the page module when colPos is hidden by TsConfig. - It does NOT resolve the issue for editors of not being to able to move content to other columns when colPos is hidden through the BE-group access list. Nevertheless a good patch, go ahead and merge, I'd say! Apparently the second issue has a different cause, I can create a new issue for that.
  15. Benni Mack voted on patch set 5 V +2 CR +2 09/04/20, 13:49

  16. Benni Mack merged patch set 6 09/04/20, 13:49

  17. Daniel Goerz voted on patch set 6 V +1 CR +1 09/04/20, 13:49