65537[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:extensionmanager
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oliver Klee +1
- Jörg Bösche +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/extensionmanager/Classes/Controller/AbstractController.php+2 −2
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+4 −3
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+2 −2
- typo3/sysext/extensionmanager/Classes/Domain/Model/DownloadQueue.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php+3 −3
- typo3/sysext/extensionmanager/Classes/Utility/Connection/TerUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Parser/ExtensionXmlPushParser.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/Parser/MirrorXmlPushParser.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+1 −0
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+2 −0
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+7 −4
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+1 −0
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ProcessAvailableActionsViewHelper.php+1 −0
Review log 1116
-
Alexander Schnitzler uploaded patch set 1 09/02/20, 11:31
-
Alexander Schnitzler wrote 09/02/20, 11:32
Topic set to phpstan -
TYPO3com voted on patch set 1 V -1 09/02/20, 11:47 Completed build in 15m 27s on Wed, 2 Sep, 11:47 AM Test Summary: 1 of 71800 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5134
-
TYPO3com voted on patch set 1 V +1 09/02/20, 15:55 Completed build in 4h 39m 35s on Wed, 2 Sep, 03:55 PM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5134
-
Jörg Bösche voted on patch set 1 V +1 CR +1 09/03/20, 09:24
-
Alexander Schnitzler updated the commit message in patch set 2 09/03/20, 15:45
-
TYPO3com voted on patch set 2 V +1 09/03/20, 16:19 Completed build in 22m 22s on Thu, 3 Sep, 04:19 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5190
-
Oliver Klee voted on patch set 2 CR +1 09/04/20, 09:50
-
Daniel Goerz uploaded patch set 3 09/05/20, 13:12
-
Daniel Goerz voted on patch set 3 V +1 CR +1 09/05/20, 13:15
-
Oliver Klee voted on patch set 3 CR +1 09/05/20, 13:17
-
TYPO3com voted on patch set 3 V -1 09/05/20, 13:23 Completed build in 10m 42s on Sat, 5 Sep, 01:23 PM Test Summary: 1 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5280
-
TYPO3com voted on patch set 3 V +1 09/05/20, 13:34 Completed build in 32m 22s on Sat, 5 Sep, 01:34 PM Test Summary: 73211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5280
-
Jörg Bösche voted on patch set 3 V +1 CR +1 09/07/20, 07:23
-
Benni Mack voted on patch set 3 V +2 CR +2 09/07/20, 07:39
-
Benni Mack merged patch set 4 09/07/20, 07:39