65538[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:scheduler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jörg Bösche +1
-
Verified V +2 Done
- Benni Mack +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
- typo3/sysext/scheduler/Classes/CronCommand/CronCommand.php+7 −7
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php1+1 −1
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+1 −1
Review log 810
-
Alexander Schnitzler uploaded patch set 1 09/02/20, 11:35
-
Alexander Schnitzler wrote 09/02/20, 11:35
Topic set to phpstan -
TYPO3com voted on patch set 1 V +1 09/02/20, 11:51 Completed build in 15m 27s on Wed, 2 Sep, 11:51 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5135
-
Jörg Bösche commented on patch set 1 CR -1 09/03/20, 09:55
FileStorageExtractionAdditionalFieldProvider.php:97UnresolvedIMO, it is better to cast as string at variable definition and not inside of the htmlspecialchars() usage. -
Alexander Schnitzler uploaded patch set 2 09/03/20, 15:54
-
TYPO3com voted on patch set 2 V +1 09/03/20, 16:28 Completed build in 30m 34s on Thu, 3 Sep, 04:28 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5196
-
Benni Mack voted on patch set 2 V +1 CR +1 09/04/20, 06:37
-
Jörg Bösche voted on patch set 2 V +1 CR +1 09/04/20, 06:56
-
Benni Mack voted on patch set 2 V +2 CR +2 09/04/20, 07:22
-
Benni Mack merged patch set 3 09/04/20, 07:22