Review main Merged

65538[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:scheduler

Alexander Schnitzler CR +2 V +2 Easy +12 −12 updated 09/04/20, 07:22

Commit message

ext:scheduler

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 810

  1. Alexander Schnitzler uploaded patch set 1 09/02/20, 11:35

  2. Alexander Schnitzler wrote 09/02/20, 11:35

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V +1 09/02/20, 11:51 Completed build in 15m 27s on Wed, 2 Sep, 11:51 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5135

  4. Jörg Bösche commented on patch set 1 CR -1 09/03/20, 09:55

    FileStorageExtractionAdditionalFieldProvider.php:97 Unresolved

    IMO, it is better to cast as string at variable definition and not inside of the htmlspecialchars() usage.
  5. Alexander Schnitzler uploaded patch set 2 09/03/20, 15:54

  6. TYPO3com voted on patch set 2 V +1 09/03/20, 16:28 Completed build in 30m 34s on Thu, 3 Sep, 04:28 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5196

  7. Benni Mack voted on patch set 2 V +1 CR +1 09/04/20, 06:37

  8. Jörg Bösche voted on patch set 2 V +1 CR +1 09/04/20, 06:56

  9. Benni Mack voted on patch set 2 V +2 CR +2 09/04/20, 07:22

  10. Benni Mack merged patch set 3 09/04/20, 07:22