Review main Merged

65539[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:linkvalidator

Alexander Schnitzler CR +2 V +2 Easy +20 −19 updated 09/04/20, 14:23

Commit message

ext:linkvalidator

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1417

  1. Alexander Schnitzler uploaded patch set 1 09/02/20, 11:38

  2. Alexander Schnitzler wrote 09/02/20, 11:40

    Topic set to phpstan
  3. Oliver Klee commented on patch set 1 09/02/20, 11:54

    EditableRestriction.php:57

    Shouldn't this be array<string, string> then?

    ValidatorTaskAdditionalFieldProvider.php:131

    Should we add array<string, string> here?
  4. TYPO3com voted on patch set 1 V +1 09/02/20, 11:56 Completed build in 14m 22s on Wed, 2 Sep, 11:56 AM Test Summary: 73163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5136

  5. Alexander Schnitzler commented on patch set 1 09/02/20, 15:44

    EditableRestriction.php:57 Reply Unresolved

    Yes, that's better.

    ValidatorTaskAdditionalFieldProvider.php:131 Reply Unresolved

    Yes, that's better.
  6. Alexander Schnitzler uploaded patch set 2 09/03/20, 15:48

  7. TYPO3com voted on patch set 2 V +1 09/03/20, 16:15 Completed build in 18m 20s on Thu, 3 Sep, 04:15 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5191

  8. Oliver Klee voted on patch set 2 CR +1 09/04/20, 07:51

  9. Benni Mack voted on patch set 2 V +1 CR +1 09/04/20, 12:10

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 09/04/20, 12:58

  11. Daniel Goerz uploaded patch set 3 09/04/20, 13:46

  12. Daniel Goerz voted on patch set 3 V +1 CR +1 09/04/20, 13:46

  13. TYPO3com voted on patch set 3 V +1 09/04/20, 13:57 Completed build in 10m 58s on Fri, 4 Sep, 01:57 PM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5241

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 09/04/20, 14:02

  15. Oliver Klee voted on patch set 3 CR +1 09/04/20, 14:06

  16. Andreas Kienast voted on patch set 3 V +2 CR +2 09/04/20, 14:23

  17. Andreas Kienast merged patch set 4 09/04/20, 14:23