65539[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+5 −5
- typo3/sysext/linkvalidator/Classes/Linktype/LinkHandler.php+1 −1
- typo3/sysext/linkvalidator/Classes/QueryRestrictions/EditableRestriction.php2+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+2 −2
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+8 −8
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php2+1 −0
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+2 −2
Review log 1417
-
Alexander Schnitzler uploaded patch set 1 09/02/20, 11:38
-
Alexander Schnitzler wrote 09/02/20, 11:40
Topic set to phpstan -
Oliver Klee commented on patch set 1 09/02/20, 11:54
EditableRestriction.php:57Shouldn't this be array<string, string> then?ValidatorTaskAdditionalFieldProvider.php:131Should we add array<string, string> here? -
TYPO3com voted on patch set 1 V +1 09/02/20, 11:56 Completed build in 14m 22s on Wed, 2 Sep, 11:56 AM Test Summary: 73163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5136
-
Alexander Schnitzler commented on patch set 1 09/02/20, 15:44
EditableRestriction.php:57Reply UnresolvedYes, that's better.ValidatorTaskAdditionalFieldProvider.php:131Reply UnresolvedYes, that's better. -
Alexander Schnitzler uploaded patch set 2 09/03/20, 15:48
-
TYPO3com voted on patch set 2 V +1 09/03/20, 16:15 Completed build in 18m 20s on Thu, 3 Sep, 04:15 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5191
-
Oliver Klee voted on patch set 2 CR +1 09/04/20, 07:51
-
Benni Mack voted on patch set 2 V +1 CR +1 09/04/20, 12:10
-
Christian Kuhn voted on patch set 2 V +1 CR +1 09/04/20, 12:58
-
Daniel Goerz uploaded patch set 3 09/04/20, 13:46
-
Daniel Goerz voted on patch set 3 V +1 CR +1 09/04/20, 13:46
-
TYPO3com voted on patch set 3 V +1 09/04/20, 13:57 Completed build in 10m 58s on Fri, 4 Sep, 01:57 PM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5241
-
Oli Bartsch voted on patch set 3 V +1 CR +1 09/04/20, 14:02
-
Oliver Klee voted on patch set 3 CR +1 09/04/20, 14:06
-
Andreas Kienast voted on patch set 3 V +2 CR +2 09/04/20, 14:23
-
Andreas Kienast merged patch set 4 09/04/20, 14:23