65540[TASK] Fix phpstan checkFunctionArgumentTypes errors in several extensions
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 6
- Task #92161Fix phpstan checkFunctionArgumentTypes errors in ext:adminpanel
- Task #92164Fix phpstan checkFunctionArgumentTypes errors in ext:dashboard
- Task #92175Fix phpstan checkFunctionArgumentTypes errors in ext:reports
- Task #92176Fix phpstan checkFunctionArgumentTypes errors in ext:rte_ckeditor
- Task #92177Fix phpstan checkFunctionArgumentTypes errors in ext:t3editor
- Task #92178Fix phpstan checkFunctionArgumentTypes errors in ext:tstemplate
Files 8
- typo3/sysext/adminpanel/Classes/Utility/MemoryUtility.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/Provider/SysLogErrorsDataProvider.php+3 −3
- typo3/sysext/reports/Classes/Report/Status/Typo3Status.php+1 −1
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+1 −1
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+3 −3
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+3 −2
- typo3/sysext/tstemplate/ext_tables.php+4 −4
Review log 1926
Show 1 earlier messages
-
Alexander Schnitzler uploaded patch set 1 09/02/20, 11:56
-
Alexander Schnitzler wrote 09/02/20, 11:56
Topic set to phpstan -
TYPO3com voted on patch set 1 V +1 09/02/20, 12:08 Completed build in 11m 59s on Wed, 2 Sep, 12:08 PM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5138
-
Jörg Bösche voted on patch set 1 CR +1 09/03/20, 09:47
-
Alexander Schnitzler updated the commit message in patch set 2 09/03/20, 15:44
-
TYPO3com voted on patch set 2 V +1 09/03/20, 16:10 Completed build in 18m 38s on Thu, 3 Sep, 04:10 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5189
-
Oliver Klee commented on patch set 2 09/04/20, 08:50
PageInfoViewHelper.php:79UnresolvedThis line is not needed after the is_array, I think.PagePathViewHelper.php:76UnresolvedThis line is not needed after the is_array, I think. -
Alexander Schnitzler uploaded patch set 3 09/04/20, 09:17
-
Alexander Schnitzler uploaded patch set 4 09/04/20, 09:18
-
Alexander Schnitzler wrote 09/04/20, 09:18
Description set to "rebase" -
TYPO3com voted on patch set 3 V -1 09/04/20, 09:20 Completed build in 22s on Fri, 4 Sep, 09:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5221
-
TYPO3com voted on patch set 4 V +1 09/04/20, 09:33 Completed build in 13m 02s on Fri, 4 Sep, 09:33 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5222
-
Oliver Klee voted on patch set 4 CR +1 09/04/20, 09:46
-
Alexander Schnitzler uploaded patch set 5 09/07/20, 11:42
-
TYPO3com voted on patch set 5 V +1 09/07/20, 11:54 Completed build in 12m 05s on Mon, 7 Sep, 11:54 AM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5319
-
Oliver Klee voted on patch set 5 CR +1 09/07/20, 12:07
-
Daniel Goerz commented on patch set 5 V -1 CR -1 09/26/20, 15:17
Let's split this one up into smaller chunks -
Daniel Goerz uploaded patch set 6 09/26/20, 17:57
-
TYPO3com voted on patch set 6 V +1 09/26/20, 18:14 Completed build in 14m 38s on Sat, 26 Sep, 06:14 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6011
-
Oliver Klee voted on patch set 6 CR +1 09/26/20, 18:22
-
Andreas Kienast uploaded patch set 7 09/27/20, 13:22
-
Andreas Kienast voted on patch set 7 V +1 CR +1 09/27/20, 13:22
-
Oli Bartsch voted on patch set 7 V +1 CR +1 09/27/20, 13:31
-
TYPO3com voted on patch set 7 V +1 09/27/20, 13:38 Completed build in 14m 44s on Sun, 27 Sep, 01:38 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6019
-
Andreas Kienast voted on patch set 7 V +2 CR +2 09/27/20, 14:20
-
Andreas Kienast merged patch set 8 09/27/20, 14:21