Review main Merged

65540[TASK] Fix phpstan checkFunctionArgumentTypes errors in several extensions

Alexander Schnitzler CR +2 V +2 Easy +17 −16 updated 09/27/20, 14:21

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 6

Files 8

Review log 1926

Show 1 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 09/02/20, 11:56

  1. Alexander Schnitzler wrote 09/02/20, 11:56

    Topic set to phpstan
  2. TYPO3com voted on patch set 1 V +1 09/02/20, 12:08 Completed build in 11m 59s on Wed, 2 Sep, 12:08 PM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5138

  3. Jörg Bösche voted on patch set 1 CR +1 09/03/20, 09:47

  4. Alexander Schnitzler updated the commit message in patch set 2 09/03/20, 15:44

  5. TYPO3com voted on patch set 2 V +1 09/03/20, 16:10 Completed build in 18m 38s on Thu, 3 Sep, 04:10 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5189

  6. Oliver Klee commented on patch set 2 09/04/20, 08:50

    PageInfoViewHelper.php:79 Unresolved

    This line is not needed after the is_array, I think.

    PagePathViewHelper.php:76 Unresolved

    This line is not needed after the is_array, I think.
  7. Alexander Schnitzler uploaded patch set 3 09/04/20, 09:17

  8. Alexander Schnitzler uploaded patch set 4 09/04/20, 09:18

  9. Alexander Schnitzler wrote 09/04/20, 09:18

    Description set to "rebase"
  10. TYPO3com voted on patch set 3 V -1 09/04/20, 09:20 Completed build in 22s on Fri, 4 Sep, 09:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5221

  11. TYPO3com voted on patch set 4 V +1 09/04/20, 09:33 Completed build in 13m 02s on Fri, 4 Sep, 09:33 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5222

  12. Oliver Klee voted on patch set 4 CR +1 09/04/20, 09:46

  13. Alexander Schnitzler uploaded patch set 5 09/07/20, 11:42

  14. TYPO3com voted on patch set 5 V +1 09/07/20, 11:54 Completed build in 12m 05s on Mon, 7 Sep, 11:54 AM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5319

  15. Oliver Klee voted on patch set 5 CR +1 09/07/20, 12:07

  16. Daniel Goerz commented on patch set 5 V -1 CR -1 09/26/20, 15:17

    Let's split this one up into smaller chunks
  17. Daniel Goerz uploaded patch set 6 09/26/20, 17:57

  18. TYPO3com voted on patch set 6 V +1 09/26/20, 18:14 Completed build in 14m 38s on Sat, 26 Sep, 06:14 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6011

  19. Oliver Klee voted on patch set 6 CR +1 09/26/20, 18:22

  20. Andreas Kienast uploaded patch set 7 09/27/20, 13:22

  21. Andreas Kienast voted on patch set 7 V +1 CR +1 09/27/20, 13:22

  22. Oli Bartsch voted on patch set 7 V +1 CR +1 09/27/20, 13:31

  23. TYPO3com voted on patch set 7 V +1 09/27/20, 13:38 Completed build in 14m 44s on Sun, 27 Sep, 01:38 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6019

  24. Andreas Kienast voted on patch set 7 V +2 CR +2 09/27/20, 14:20

  25. Andreas Kienast merged patch set 8 09/27/20, 14:21