Review main Merged

65541[BUGFIX] Fixes annotation of parameter in ExtensionConfiguration

Timo Poppinga CR +2 V +2 Easy +1 −1 updated 09/04/20, 11:39

Commit message

Add mixed annotation of parameter $value in ExtensionConfiguration
of method set. The static code analysis tools line phpstan can deal
with it

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Timo Poppinga uploaded patch set 1 09/02/20, 15:50

  2. TYPO3com voted on patch set 1 V -1 09/02/20, 16:03 Completed build in 12m 29s on Wed, 2 Sep, 04:03 PM Test Summary: 8611 of 72336 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5147

  3. Timo Poppinga uploaded patch set 2 09/02/20, 19:03

  4. Timo Poppinga updated the commit message in patch set 3 09/02/20, 19:07

  5. TYPO3com voted on patch set 2 V +1 09/02/20, 19:15 Completed build in 11m 49s on Wed, 2 Sep, 07:15 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5152

  6. TYPO3com voted on patch set 3 V +1 09/02/20, 19:24 Completed build in 13m 01s on Wed, 2 Sep, 07:24 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5154

  7. Alexander Schnitzler commented on patch set 3 09/02/20, 20:02

    Do you have the phpstan error at hand? Annd maybe also the level? I am asking because we have quite a lot of phpstan checks active in the core and until now no active check triggered this and we usually deal with phpstan errors in bunches like here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65465 I appreciate more and more people finding and fixing wrong types but doing this error by error is tedious as phpstan currently finds thousands of errors for the whole core on level max.
  8. Alexander Schnitzler wrote 09/02/20, 20:06

    Topic set to phpstan
  9. Timo Poppinga commented on patch set 3 09/02/20, 20:08

    > Patch Set 3: > > Do you have the phpstan error at hand? Annd maybe also the level? I am asking because we have quite a lot of phpstan checks active in the core and until now no active check triggered this and we usually deal with phpstan errors in bunches like here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65465 > > I appreciate more and more people finding and fixing wrong types but doing this error by error is tedious as phpstan currently finds thousands of errors for the whole core on level max. Hi Alex, i'am using --level max the error is Parameter #3 $value of method TYPO3\CMS\Core\Configuration\ExtensionConfiguration::set() expects null, string given.
  10. Timo Poppinga commented on patch set 3 09/02/20, 20:09

    > Patch Set 3: > > > Patch Set 3: > > > > Do you have the phpstan error at hand? Annd maybe also the level? I am asking because we have quite a lot of phpstan checks active in the core and until now no active check triggered this and we usually deal with phpstan errors in bunches like here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65465 > > > > I appreciate more and more people finding and fixing wrong types but doing this error by error is tedious as phpstan currently finds thousands of errors for the whole core on level max. > > Hi Alex, i'am using --level max the error is Parameter #3 $value of method TYPO3\CMS\Core\Configuration\ExtensionConfiguration::set() expects null, string given. /** * @param string $key * @param string $value */ public function writeConfig(string $key, string $value): void { $this->extensionConfiguration->set('gitlab_backend_login', $key, $value); }
  11. Oliver Klee voted on patch set 3 CR +1 09/04/20, 07:53

  12. Alexander Schnitzler voted on patch set 3 V +1 CR +1 09/04/20, 07:58

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 09/04/20, 11:17

  14. Daniel Goerz merged patch set 4 09/04/20, 11:17

  15. Tymoteusz Motylewski commented on patch set 4 09/04/20, 11:26

    ExtensionConfiguration.php:146

    can't we be more specific e.g. null|array|? does one really can pass any type of data as a value?
  16. Timo Poppinga commented on patch set 4 09/04/20, 11:39

    > Patch Set 4: > > (1 comment)

    ExtensionConfiguration.php:146 Reply Unresolved