Review main Merged

65542[BUGFIX] Do not set a label for workspace placeholders

Benni Mack CR +2 V +2 Easy +15 −8 updated 09/03/20, 19:50

Commit message

When adding a new record (or moving a record) in a workspace,
the TCA[table][ctrl][label] field is filled with a static label
(e.g. "[PLACEHOLDER, WS #1]") which only makes sense
for TCA tables where the label field is an input field, otherwise
label fields (in sys_file_metadata) which are numeric ("sys_file_metadata.file")
will never be allowed to be translated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 712

  1. Benni Mack uploaded patch set 1 09/02/20, 21:28

  2. TYPO3com voted on patch set 1 V -1 09/02/20, 21:43 Completed build in 14m 51s on Wed, 2 Sep, 09:43 PM Test Summary: 173 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5156

  3. Benni Mack uploaded patch set 2 09/02/20, 21:44

  4. TYPO3com voted on patch set 2 V -1 09/02/20, 21:56 Completed build in 12m 09s on Wed, 2 Sep, 09:56 PM Test Summary: 7 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5158

  5. TYPO3com commented on patch set 2 09/02/20, 22:03 Completed build in 30m 51s on Wed, 2 Sep, 10:03 PM Test Summary: 6 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5158

  6. Benni Mack uploaded patch set 3 09/03/20, 11:28

  7. TYPO3com voted on patch set 3 V +1 09/03/20, 11:43 Completed build in 14m 37s on Thu, 3 Sep, 11:43 AM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5170

  8. Benni Mack updated the commit message in patch set 4 09/03/20, 12:58

  9. TYPO3com voted on patch set 4 V +1 09/03/20, 13:10 Completed build in 12m 13s on Thu, 3 Sep, 01:10 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5177

  10. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/03/20, 19:49

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 09/03/20, 19:49

  12. Christian Kuhn merged patch set 5 09/03/20, 19:50