Review main Merged

65543[BUGFIX] Correctly build query string without cHash

Helmut Hummel CR +2 V +2 Normal +89 −3 updated 09/06/20, 13:13

Commit message

For building URIs using the Symfony routing,
array URL arguments are deflated (foo[bar] -> foo__bar).

In case the final URI contains a remaining query string,
the arguments get inflated again. However the
query string of the URI is currently only updated, when
at least one of the remaining arguments require a cHash.

In case remaining arguments exist, the query string
needs to be always updated, whether the URI requires
a cHash or not.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Nicole Hummel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Nicole Hummel +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 811

  1. Helmut Hummel uploaded patch set 1 09/03/20, 07:15

  2. TYPO3com voted on patch set 1 V +1 09/03/20, 07:25 Completed build in 10m 29s on Thu, 3 Sep, 07:25 AM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5159

  3. Benni Mack uploaded patch set 2 09/03/20, 08:26

  4. Benni Mack voted on patch set 2 V +1 CR +1 09/03/20, 08:26

  5. TYPO3com voted on patch set 2 V -1 09/03/20, 08:37 Completed build in 10m 43s on Thu, 3 Sep, 08:37 AM Test Summary: 15 of 73682 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5160

  6. Benni Mack uploaded patch set 3 09/03/20, 10:31

  7. TYPO3com voted on patch set 3 V +1 09/03/20, 10:43 Completed build in 11m 34s on Thu, 3 Sep, 10:43 AM Test Summary: 73197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5167

  8. Benni Mack voted on patch set 3 V +1 CR +1 09/03/20, 10:45

  9. Nicole Hummel voted on patch set 3 V +1 CR +1 09/06/20, 12:32

  10. Helmut Hummel voted on patch set 3 V +2 CR +2 09/06/20, 13:13

  11. Helmut Hummel merged patch set 4 09/06/20, 13:13