Review main Merged

65545[BUGFIX] Skip -1 as language column in fluid based page layout

Oli Bartsch CR +2 V +2 Easy +3 −0 updated 09/05/20, 13:36

Commit message

Since #90854 the siteLanguages array also contains the
-1 language which must be skipped because it otherwise
falls back and generates another default language column.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Riccardo De Contardi +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 09/03/20, 09:47

  2. TYPO3com voted on patch set 1 V +1 09/03/20, 10:00 Completed build in 12m 48s on Thu, 3 Sep, 10:00 AM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5162

  3. Riccardo De Contardi commented on patch set 1 09/04/20, 21:34

    seems to work on latest master
  4. Riccardo De Contardi voted on patch set 1 V +1 09/04/20, 21:34

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 09/05/20, 09:29

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 09/05/20, 13:36

  7. Daniel Goerz merged patch set 2 09/05/20, 13:36