Review main Merged Breaking

65548[!!!][BUGFIX] Do not render type attribute for style and link tags

Benni Mack CR +2 V +2 Normal +67 −25 updated 11/10/20, 18:38

Commit message

It is recommended for <style> and <link> HTML tags
to not use the "type" attribute anymore.

Details:
* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link
* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style

The patch drops the attribute from rendering. The patch is
marked as a breaking since it changes frontend output.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1422

  1. Benni Mack uploaded patch set 1 09/03/20, 14:43

  2. TYPO3com voted on patch set 1 V -1 09/03/20, 14:55 Completed build in 11m 44s on Thu, 3 Sep, 02:55 PM Test Summary: 6 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5181

  3. Benni Mack uploaded patch set 2 09/12/20, 18:41

  4. TYPO3com voted on patch set 2 V -1 09/12/20, 18:53 Completed build in 11m 05s on Sat, 12 Sep, 06:53 PM Test Summary: 1 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5562

  5. Benni Mack uploaded patch set 3 09/14/20, 20:12

  6. TYPO3com voted on patch set 3 V +1 09/14/20, 20:28 Completed build in 15m 50s on Mon, 14 Sep, 08:28 PM Test Summary: 73239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5614

  7. Georg Ringer rebased onto patch set 4 10/23/20, 08:28

  8. TYPO3com voted on patch set 4 V +1 10/23/20, 08:40 Completed build in 12m 16s on Fri, 23 Oct, 08:40 AM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6821

  9. Georg Ringer uploaded patch set 5 11/03/20, 09:20

  10. TYPO3com voted on patch set 5 V -1 11/03/20, 09:32 Completed build in 12m 24s on Tue, 3 Nov, 09:32 AM Test Summary: 18 of 74054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7082

  11. Georg Ringer uploaded patch set 6 11/03/20, 13:24

  12. TYPO3com voted on patch set 6 V +1 11/03/20, 13:37 Completed build in 12m 48s on Tue, 3 Nov, 01:37 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7088

  13. Markus Klein commented on patch set 6 CR +1 11/03/20, 13:57

    I'm pretty sure there are some edge-cases where it might still be needed to generate a type attribute (old HTML markup for mails or similar stuff), but I'm fine with the change.
  14. Benni Mack commented on patch set 6 CR -1 11/03/20, 16:36

    Haha, you've copied over the commit message to the RST ;) - I will adapt it.
  15. Benni Mack uploaded patch set 7 11/03/20, 16:44

  16. Benni Mack voted on patch set 7 V +1 CR +1 11/03/20, 16:44

  17. TYPO3com voted on patch set 7 V +1 11/03/20, 16:56 Completed build in 11m 39s on Tue, 3 Nov, 04:56 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7094

  18. Christian Kuhn uploaded patch set 8 11/10/20, 18:04

  19. Christian Kuhn voted on patch set 8 V +1 CR +1 11/10/20, 18:04

  20. TYPO3com voted on patch set 8 V +1 11/10/20, 18:17 Completed build in 12m 31s on Tue, 10 Nov, 06:17 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7231

  21. Georg Ringer voted on patch set 8 V +2 CR +2 11/10/20, 18:38

  22. Georg Ringer merged patch set 9 11/10/20, 18:38