65548[!!!][BUGFIX] Do not render type attribute for style and link tags
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/adminpanel/Classes/Utility/ResourceUtility.php+2 −2
- typo3/sysext/core/Classes/Page/AssetRenderer.php+0 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+3 −3
- typo3/sysext/core/Documentation/Changelog/master/Breaking-45512-NoTypeAttributesForStyleAndLinkTags.rstnew+43 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Page/AssetDataProvider.php+12 −12
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Controller/Fixtures/renderedPage.html+1 −1
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+2 −2
- typo3/sysext/install/Resources/Private/Templates/Installer/Init.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Layout/Init.html+1 −1
Review log 1422
-
Benni Mack uploaded patch set 1 09/03/20, 14:43
-
TYPO3com voted on patch set 1 V -1 09/03/20, 14:55 Completed build in 11m 44s on Thu, 3 Sep, 02:55 PM Test Summary: 6 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5181
-
Benni Mack uploaded patch set 2 09/12/20, 18:41
-
TYPO3com voted on patch set 2 V -1 09/12/20, 18:53 Completed build in 11m 05s on Sat, 12 Sep, 06:53 PM Test Summary: 1 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5562
-
Benni Mack uploaded patch set 3 09/14/20, 20:12
-
TYPO3com voted on patch set 3 V +1 09/14/20, 20:28 Completed build in 15m 50s on Mon, 14 Sep, 08:28 PM Test Summary: 73239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5614
-
Georg Ringer rebased onto patch set 4 10/23/20, 08:28
-
TYPO3com voted on patch set 4 V +1 10/23/20, 08:40 Completed build in 12m 16s on Fri, 23 Oct, 08:40 AM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6821
-
Georg Ringer uploaded patch set 5 11/03/20, 09:20
-
TYPO3com voted on patch set 5 V -1 11/03/20, 09:32 Completed build in 12m 24s on Tue, 3 Nov, 09:32 AM Test Summary: 18 of 74054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7082
-
Georg Ringer uploaded patch set 6 11/03/20, 13:24
-
TYPO3com voted on patch set 6 V +1 11/03/20, 13:37 Completed build in 12m 48s on Tue, 3 Nov, 01:37 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7088
-
Markus Klein commented on patch set 6 CR +1 11/03/20, 13:57
I'm pretty sure there are some edge-cases where it might still be needed to generate a type attribute (old HTML markup for mails or similar stuff), but I'm fine with the change. -
Benni Mack commented on patch set 6 CR -1 11/03/20, 16:36
Haha, you've copied over the commit message to the RST ;) - I will adapt it. -
Benni Mack uploaded patch set 7 11/03/20, 16:44
-
Benni Mack voted on patch set 7 V +1 CR +1 11/03/20, 16:44
-
TYPO3com voted on patch set 7 V +1 11/03/20, 16:56 Completed build in 11m 39s on Tue, 3 Nov, 04:56 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7094
-
Christian Kuhn uploaded patch set 8 11/10/20, 18:04
-
Christian Kuhn voted on patch set 8 V +1 CR +1 11/10/20, 18:04
-
TYPO3com voted on patch set 8 V +1 11/10/20, 18:17 Completed build in 12m 31s on Tue, 10 Nov, 06:17 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7231
-
Georg Ringer voted on patch set 8 V +2 CR +2 11/10/20, 18:38
-
Georg Ringer merged patch set 9 11/10/20, 18:38