65553[BUGFIX] Correctly show changes in current workspace in the page tree
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Richard Haeser +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Richard Haeser +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 4
- Bug #92041Move-placeholders not considered in page tree
- Bug #92057Workspace delete placeholder not considered in pagetree
- Bug #92096Page tree search does not consider workspaces
- Bug #91652In the workspaces, if a page is new and still is in draft mode, when I move it, the pid is correctly changed but the sorting is not
Files 7
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php2+3 −2
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+132 −50
- typo3/sysext/backend/Tests/Functional/Controller/Page/Fixtures/PagesWithBEPermissions.yaml+16 −0
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+145 −26
- typo3/sysext/core/composer.json+1 −1
- composer.json+1 −1
- composer.lock+342 −7
Review log 1619
-
Benni Mack commented on patch set 1 09/02/20, 14:54
Cherry Picked from branch 10.4. -
TYPO3com voted on patch set 1 V -1 09/02/20, 15:08 Completed build in 14m 14s on Wed, 2 Sep, 03:08 PM Test Summary: 12 of 75763 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-769
-
Benni Mack uploaded patch set 2 09/02/20, 21:12
-
TYPO3com voted on patch set 2 V -1 09/02/20, 21:25 Completed build in 13m 16s on Wed, 2 Sep, 09:25 PM Test Summary: 6 of 75763 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-770
-
Benni Mack uploaded patch set 3 09/03/20, 10:48
-
TYPO3com voted on patch set 3 V +1 09/03/20, 11:01 Completed build in 12m 54s on Thu, 3 Sep, 11:01 AM Test Summary: 75163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-771
-
Claus Due commented on patch set 3 09/03/20, 12:40
TreeController.php:512I realise this may not be the right place since this is a backport, but this cast is redundant - the value is already cast to int in line 508 and can't be redefined inbetween that line and this line. The cast also doesn't appear to be related to the change. -
Benni Mack commented on patch set 3 09/03/20, 14:27
TreeController.php:512Reply Unresolvedyeah, I agree (don't know why I missed that when reviewing / working on the master patch). however, as this is merged in master/v10.4 I'd keep it for now. -
Richard Haeser commented on patch set 3 09/03/20, 17:43
Found one small renaming / moving combination issue: - Alter the title of an existing page in draft - Move the page with the altered title to another parent - Check the title, it is the title of the live workspace again BTW when searching after the steps above on the new title, you will see the tree with the new title from the draft workspace. -
Benni Mack commented on patch set 3 09/04/20, 06:03
> Patch Set 3: > > Found one small renaming / moving combination issue: > - Alter the title of an existing page in draft > - Move the page with the altered title to another parent > - Check the title, it is the title of the live workspace again > > BTW when searching after the steps above on the new title, you will see the tree with the new title from the draft workspace. ah, OK. so search/filtering is working with moved records, but not the actual rendering on a per-tree-level basis. This is an important issue to fix. Can you also check this in a master/v10 installation? On which level did you change the title of the page? -
Richard Haeser commented on patch set 3 09/04/20, 06:10
> Patch Set 3: > > > Patch Set 3: > > > > Found one small renaming / moving combination issue: > > - Alter the title of an existing page in draft > > - Move the page with the altered title to another parent > > - Check the title, it is the title of the live workspace again > > > > BTW when searching after the steps above on the new title, you will see the tree with the new title from the draft workspace. > > ah, OK. so search/filtering is working with moved records, but not the actual rendering on a per-tree-level basis. This is an important issue to fix. Can you also check this in a master/v10 installation? On which level did you change the title of the page? Search/filtering is working correctly indeed. Only after the move of a renamed page, you see the old name of the page. It doesn't matter which level as far as I have seen. Will check v10 and master as well. If I find anything on that, I will add a post-merge-message on the according patches. Another thing I found is that moving a page from a non-default doktype, will show the default doktype (page) icon after moving in the page-tree. Will check on v10 / master as well. -
Richard Haeser commented on patch set 3 09/04/20, 06:14
> Patch Set 3: > > > Patch Set 3: > > > > Found one small renaming / moving combination issue: > > - Alter the title of an existing page in draft > > - Move the page with the altered title to another parent > > - Check the title, it is the title of the live workspace again > > > > BTW when searching after the steps above on the new title, you will see the tree with the new title from the draft workspace. > > ah, OK. so search/filtering is working with moved records, but not the actual rendering on a per-tree-level basis. This is an important issue to fix. Can you also check this in a master/v10 installation? On which level did you change the title of the page? This is indeed same in master. I will create a new issue for this on forge. -
Richard Haeser commented on patch set 3 09/04/20, 06:20
> Patch Set 3: > > > Patch Set 3: > > > > > Patch Set 3: > > > > > > Found one small renaming / moving combination issue: > > > - Alter the title of an existing page in draft > > > - Move the page with the altered title to another parent > > > - Check the title, it is the title of the live workspace again > > > > > > BTW when searching after the steps above on the new title, you will see the tree with the new title from the draft workspace. > > > > ah, OK. so search/filtering is working with moved records, but not the actual rendering on a per-tree-level basis. This is an important issue to fix. Can you also check this in a master/v10 installation? On which level did you change the title of the page? > > This is indeed same in master. I will create a new issue for this on forge. https://forge.typo3.org/issues/92191 -
Richard Haeser commented on patch set 3 09/04/20, 06:20
> Patch Set 3: > > > Patch Set 3: > > > > > Patch Set 3: > > > > > > Found one small renaming / moving combination issue: > > > - Alter the title of an existing page in draft > > > - Move the page with the altered title to another parent > > > - Check the title, it is the title of the live workspace again > > > > > > BTW when searching after the steps above on the new title, you will see the tree with the new title from the draft workspace. > > > > ah, OK. so search/filtering is working with moved records, but not the actual rendering on a per-tree-level basis. This is an important issue to fix. Can you also check this in a master/v10 installation? On which level did you change the title of the page? > > Search/filtering is working correctly indeed. Only after the move of a renamed page, you see the old name of the page. It doesn't matter which level as far as I have seen. Will check v10 and master as well. If I find anything on that, I will add a post-merge-message on the according patches. > > Another thing I found is that moving a page from a non-default doktype, will show the default doktype (page) icon after moving in the page-tree. Will check on v10 / master as well. The wrong icon is only v9 as far as I can see -
Andreas Kienast voted on patch set 3 V +1 CR +1 09/05/20, 09:26
-
Richard Haeser voted on patch set 3 V +1 CR +1 09/07/20, 08:41
-
Richard Haeser commented on patch set 3 09/07/20, 08:49
I think this patch already solves a lot of issues and it would be great to get this merged. -
Benni Mack voted on patch set 3 V +2 CR +2 09/07/20, 09:16
-
Benni Mack merged patch set 4 09/07/20, 09:16