Review 10.4 Merged

65554[TASK] Improve and fix ThumbnailController

Helmut Hummel CR +2 V +2 Easy +29 −21 updated 09/12/20, 12:37

Commit message

The ThumbnailController outputs raw data of image files
as a response to a file process request.
This is a massive and unnecessary performance hit, when using
a remote storage, as the files need to get downloaded from
the remote to be then delivered by TYPO3.

This is now changed to simply redirect to the file URL.

Also the mime-type check for images is replaced with
an isImage() call to the processed file, in order
to also properly deliver thumbnails of PDF files.

Also clarify in code, that ProcessedFile::CONTEXT_IMAGEPREVIEW
isn't capable of handling any other processing instruction
than "width" and "height".

Also fix delivering an icon as thumbnail,
when the processed file isn't an image.

Last but not least, fix the 404 response by using
a HtmlResponse instead of a plain Response object,
because the plain Response object needs a resource
and cannot deal with plain strings.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 57

  1. Helmut Hummel commented on patch set 1 09/03/20, 08:52

    Cherry Picked from branch master.
  2. Helmut Hummel commented on patch set 1 CR -2 09/03/20, 08:52

    Delayed until next release
  3. TYPO3com voted on patch set 1 V -1 09/03/20, 09:03 Completed build in 11m 23s on Thu, 3 Sep, 09:03 AM Test Summary: 1 of 74636 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-308

  4. Helmut Hummel voted on patch set 1 V +2 CR +2 09/08/20, 12:19

  5. TYPO3com voted on patch set 1 V +1 09/08/20, 12:30 Completed build in 11m 56s on Tue, 8 Sep, 12:30 PM Test Summary: 74188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-366

  6. Jörg Bösche voted on patch set 1 CR +1 09/11/20, 07:50

  7. Helmut Hummel merged patch set 2 09/12/20, 12:37