Review 10.4 Merged

65556[TASK] Extract SVG image processing into processor

Helmut Hummel CR +2 V +2 Hard +518 −111 updated 09/12/20, 12:36

Commit message

Instead of spreading (similar) code that handles SVG
files in multiple classes with conditional code
branching, processing SVG files (mostly calculating
new width and height according to the configuration)
is now placed in an own file processor.

Cropping SVGs is still done like before using IM/GM
and resulting in an png image. In this case the new
processor is skipped and the file is passed to the
existing LocalImageProcessor.

A new class is introduced, which calculates resulting
image dimension from an original dimension and a given
processing task.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 68

  1. Helmut Hummel commented on patch set 1 09/03/20, 09:54

    Cherry Picked from branch master.
  2. Helmut Hummel uploaded patch set 2 09/03/20, 09:56

  3. TYPO3com voted on patch set 1 V +1 09/03/20, 10:07 Completed build in 12m 05s on Thu, 3 Sep, 10:07 AM Test Summary: 74229 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-310

  4. TYPO3com commented on patch set 2 09/03/20, 10:11 Completed build in 13m 51s on Thu, 3 Sep, 10:11 AM Test Summary: 74229 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-311

  5. Helmut Hummel commented on patch set 2 CR -2 09/06/20, 13:15

    blocked until next release
  6. Helmut Hummel voted on patch set 2 V +2 CR +2 09/08/20, 21:41

  7. Jörg Bösche voted on patch set 2 CR +1 09/09/20, 07:04

  8. Helmut Hummel merged patch set 3 09/12/20, 12:36