Review 10.4 Merged

65558[BUGFIX] Do not set a label for workspace placeholders

Christian Kuhn CR +2 V +2 Easy +15 −8 updated 09/03/20, 20:10

Commit message

When adding a new record (or moving a record) in a workspace,
the TCA[table][ctrl][label] field is filled with a static label
(e.g. "[PLACEHOLDER, WS #1]") which only makes sense
for TCA tables where the label field is an input field, otherwise
label fields (in sys_file_metadata) which are numeric ("sys_file_metadata.file")
will never be allowed to be translated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Christian Kuhn commented on patch set 1 09/03/20, 19:50

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/03/20, 20:03 Completed build in 12m 47s on Thu, 3 Sep, 08:03 PM Test Summary: 74151 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-315

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/03/20, 20:09

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 09/03/20, 20:10

  5. Christian Kuhn merged patch set 2 09/03/20, 20:10