Review 10.4 Merged

65564[TASK] Update build toolchain

Benni Mack CR +2 V +2 Expert +960 −687 updated 09/04/20, 12:04

Commit message

This patch updates some tools used for our assets generation toolchain.

Most notable changes:

- Since typescript-eslint has been updated to a new major version, its
  configuration changes slightly
- TypeScript is updated to 3.9

Executed commands:

  yarn add --dev \
      "@typescript-eslint/eslint-plugin"@^3.8.0 \
      "@typescript-eslint/parser"@^3.8.0 \
      "@typescript-eslint/typescript-estree"@^3.8.0 \
      autoprefixer@^9.8.6 \
      eslint@^7.6.0 \
      grunt-eslint@^23.0.0 \
      grunt-lintspaces@^0.9.0 \
      jasmine-core@^3.6.0 \
      karma@^5.1.1 \
      karma-coverage@^2.0.3 \
      karma-jasmine@^3.3.1 \
      terser@^5.0.0 \
      typescript@~3.9.0
  grunt build

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 26

Show 6 more files

Review log 57

  1. Benni Mack commented on patch set 1 09/04/20, 06:38

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/yarn.lock * typo3/sysext/backend/Resources/Public/JavaScript/DragUploader.js * typo3/sysext/backend/Resources/Public/JavaScript/Element/ImmediateActionElement.js
  2. TYPO3com voted on patch set 1 V -1 09/04/20, 06:49 Completed build in 10m 54s on Fri, 4 Sep, 06:49 AM Test Summary: 82 of 74654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-323

  3. Andreas Kienast uploaded patch set 2 09/04/20, 11:32

  4. TYPO3com voted on patch set 2 V +1 09/04/20, 11:47 Completed build in 12m 07s on Fri, 4 Sep, 11:47 AM Test Summary: 74169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-334

  5. Benni Mack commented on patch set 2 09/04/20, 12:04

    This change is ready for review.
  6. Benni Mack voted on patch set 2 V +2 CR +2 09/04/20, 12:04

  7. Benni Mack merged patch set 3 09/04/20, 12:04