Review 10.4 Merged

65565[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:scheduler

Benni Mack CR +2 V +2 Easy +12 −12 updated 09/04/20, 08:05

Commit message

ext:scheduler

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 45

  1. Benni Mack commented on patch set 1 09/04/20, 07:22

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/04/20, 07:34 Completed build in 11m 42s on Fri, 4 Sep, 07:33 AM Test Summary: 74169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-324

  3. Alexander Schnitzler commented on patch set 1 V +1 CR +1 09/04/20, 07:52

    bin/phpstan analyze typo3/sysext/scheduler is green with checkFunctionArgumentTypes enabled
  4. Benni Mack voted on patch set 1 V +2 CR +2 09/04/20, 08:05

  5. Benni Mack merged patch set 2 09/04/20, 08:05