Review 10.4 Merged

65567[BUGFIX] Fixes annotation of parameter in ExtensionConfiguration

Daniel Goerz CR +2 V +2 Easy +1 −1 updated 09/04/20, 11:48

Commit message

Add mixed annotation of parameter $value in ExtensionConfiguration
of method set. The static code analysis tools line phpstan can deal
with it

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 09/04/20, 11:17

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/04/20, 11:31 Completed build in 14m 10s on Fri, 4 Sep, 11:31 AM Test Summary: 74169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-332

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 09/04/20, 11:48

  4. Daniel Goerz merged patch set 2 09/04/20, 11:48