Review 10.4 Merged

65568[BUGFIX] Do not create Install Tool cookie if not needed

Benni Mack CR +2 V +2 Normal +89 −65 updated 09/04/20, 13:19

Commit message

This change corrects the Install Tool cookie handling in various ways:

1.) It is ensured that the cookie is removed on log off
2.) Session files (var/session/*) are always removed
3.) No cookie is set until it is really needed (during login)
4.) Session expire calculation is centralized into a single method

This is done by adjusting the SessionService:
 - Move session_start() from the constructor to a dedicated method
 - Session existence check employs a cookie existence check
   before loading an existing session into memory and validating it
 - destroySession() now explicitly removes the cookie
 - renewSession() lets session_regenerate_id() deleted old session data

The Install Tool is adjusted to separate action treatment for actions
requiring session interaction and those not.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 09/04/20, 13:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/04/20, 13:12 Completed build in 11m 17s on Fri, 4 Sep, 01:12 PM Test Summary: 74169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-338

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/04/20, 13:19

  4. Benni Mack merged patch set 2 09/04/20, 13:19