Review 10.4 Merged

65569[BUGFIX] Apply default values before processing datamap

Benni Mack CR +2 V +2 Normal +156 −0 updated 09/04/20, 14:02

Commit message

By creating new records the EditDocumentController did not take the
default values fetched via GET / Post variables into account. This led
to multiple issues when defining columns to be readOnly, disabled or
hideForNonAdmins as the values are then stored in defVals parameter
but never added to the final datamap.

The default values are now being added to the Datahandler prior
to process_datamap call.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 09/04/20, 13:49

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/04/20, 14:01 Completed build in 11m 42s on Fri, 4 Sep, 02:01 PM Test Summary: 74175 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-339

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/04/20, 14:02

  4. Benni Mack merged patch set 2 09/04/20, 14:02