Review 10.4 Merged

65570[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:linkvalidator

Andreas Kienast CR +2 V +2 Easy +20 −19 updated 09/04/20, 15:10

Commit message

ext:linkvalidator

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 34

  1. Andreas Kienast commented on patch set 1 09/04/20, 14:24

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/04/20, 14:35 Completed build in 11m 06s on Fri, 4 Sep, 02:35 PM Test Summary: 74175 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-340

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 09/04/20, 15:10

  4. Andreas Kienast merged patch set 2 09/04/20, 15:10