Review main Merged

65574[TASK] DatabaseRecordList: Streamline `returnUrl`

Daniel Windloff CR +2 V +2 Normal +65 −39 updated 09/04/20, 15:04

Commit message

The method `listURL()` is used to set the `returnUrl` for all actions
in the `DatabaseRecordList`.
It replaces the usages of the method `makeReturnUrl`. Therefore, this
method has been removed. Furthermore,
`GeneralUtility::getIndpEnv('REQUEST_URI')` has been replaced by
`listURL()`.
This leads to a consistent behaviour after performing any kind of
action in the `DatabaseRecordList`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 79

  1. Daniel Windloff uploaded patch set 1 09/04/20, 08:01

  2. TYPO3com voted on patch set 1 V +1 09/04/20, 08:17 Completed build in 14m 03s on Fri, 4 Sep, 08:17 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5212

  3. Benni Mack commented on patch set 1 09/04/20, 09:46

    great. thanks for the patch! see my remarks, would be great if we make it "right" from the start.

    DatabaseRecordList.php:556 Unresolved

    can you please add the $params as array (into the second argument of buildUriFromRoute()) directly? This is much more how code should work in TYPO3 in general when using linking.-

    DatabaseRecordList.php:1368 Unresolved

    see comment above

    DatabaseRecordList.php:1447 Unresolved

    see comment above.
  4. Daniel Windloff commented on patch set 1 09/04/20, 10:13

    > Patch Set 1: > > (3 comments) > > great. thanks for the patch! see my remarks, would be great if we make it "right" from the start. I don't want to do it "right" right now, as I try to concentrate on small refactoring areas. These areas could be reviewed and tested more easily. This works pretty well in comparison to my tries last year, where I try to do it "right" for a single topic from the beginning. To move the parameters to the right place is already on my to-do list. It needs some groundwork in the JavaScript area, as the scripts sometimes expect uncoded url parts. That's why I would avoid it doing that on that patch.
  5. Benni Mack uploaded patch set 2 09/04/20, 11:43

  6. TYPO3com voted on patch set 2 V +1 09/04/20, 12:02 Completed build in 13m 07s on Fri, 4 Sep, 12:02 PM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5234

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 09/04/20, 15:00

  8. Benni Mack voted on patch set 2 V +2 CR +2 09/04/20, 15:04

  9. Benni Mack merged patch set 3 09/04/20, 15:04