Review 10.4 Abandoned

65578[TASK] Streamline AjaxDataHandler

Oliver Hader CR 0 V 0 Hard +295 −112 updated 11/04/21, 12:59

Commit message

* Streamlines messages being sent in AjaxDataHandler

  The same event was emitted twice as message to BroadcastChannel and
  as CustomEvent to current document - now it's only broadcasted, which
  internall emits to currrent document (in case there's a subscription)

  Event names have been streamlined and now are
  * typo3:ajax-data-handler:process-failed (+ meta-data, response)
  * typo3:ajax-data-handler:process-successed (+ meta-data, response)

* Listens to incoming broadcast messages

  Using message type `typo3:ajax-data-handler:instruction@<token>`, the
  internal AjaxDataHandler processing can be triggered for knwon actions.
  `<token>` is an internal random value to ensure that each instance of
  AjaxDataHandler is only handling responses they actually initiated.

These changes allow https://github.com/FriendsOfTYPO3/sudo-mode to
intercept and handle failed requests to server-side DataHandler.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 1017

  1. Oliver Hader uploaded patch set 1 09/04/20, 11:36

  2. TYPO3com voted on patch set 1 V +1 09/04/20, 11:52 Completed build in 12m 42s on Fri, 4 Sep, 11:52 AM Test Summary: 74169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-335

  3. Oliver Hader uploaded patch set 2 09/04/20, 12:56

  4. Oliver Hader commented on patch set 2 09/04/20, 12:58

    Interfaces.js:13 Unresolved

    How can we get rid of these empty modules?
  5. TYPO3com voted on patch set 2 V +1 09/04/20, 13:08 Completed build in 11m 53s on Fri, 4 Sep, 01:08 PM Test Summary: 74169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-337

  6. Oliver Hader uploaded patch set 3 09/04/20, 23:53

  7. TYPO3com voted on patch set 3 V +1 09/05/20, 00:06 Completed build in 12m 07s on Sat, 5 Sep, 12:06 AM Test Summary: 74175 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-341

  8. Oliver Hader uploaded patch set 4 09/07/20, 08:04

  9. Oliver Hader commented on patch set 4 09/07/20, 08:05

    Focussing on v10.4 first for compat reasons
  10. TYPO3com voted on patch set 4 V +1 09/07/20, 08:20 Completed build in 11m 35s on Mon, 7 Sep, 08:20 AM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-350

  11. Oliver Hader uploaded patch set 5 09/07/20, 11:51

  12. TYPO3com voted on patch set 5 V -1 09/07/20, 12:03 Completed build in 11m 54s on Mon, 7 Sep, 12:03 PM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-352

  13. Oliver Hader uploaded patch set 6 09/07/20, 15:37

  14. TYPO3com voted on patch set 6 V -1 09/07/20, 15:50 Completed build in 11m 57s on Mon, 7 Sep, 03:49 PM Test Summary: 1 of 74675 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-356

  15. Oliver Hader uploaded patch set 7 09/07/20, 18:46

  16. TYPO3com voted on patch set 7 V +1 09/07/20, 19:10 Completed build in 21m 45s on Mon, 7 Sep, 07:10 PM Test Summary: 74188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-360

  17. Benni Mack abandoned the change 11/04/21, 12:59

    won't do this for v10