Review main Abandoned

65581[TASK] DatabaseRecordList: Add `table` in `getQueryBuilder`

Daniel Windloff CR 0 V 0 Easy +30 −14 updated 11/04/21, 16:27

Commit message

As preparation for further refactoring, the main `getQueryBuilder`
method in DatabaseRecordList uses the `table` in the query.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Daniel Windloff uploaded patch set 1 09/05/20, 04:32

  2. TYPO3com voted on patch set 1 V +1 09/05/20, 04:43 Completed build in 10m 51s on Sat, 5 Sep, 04:43 AM Test Summary: 73204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5250

  3. Daniel Windloff commented on patch set 1 09/05/20, 07:35

    Problems with tca addWhere are possible.
  4. Daniel Windloff marked it work in progress 09/05/20, 07:36

  5. Christian Kuhn commented on patch set 1 11/04/21, 16:26

    Hey. I hope it's ok to abandon this for now: Quite a bit happened in database reccord list meanwhile, the patch conflicts and the issue might be solved differently meanwhile. Let's drop the patch for now. It's of course always possible to resurrect it if needed.
  6. Christian Kuhn abandoned the change 11/04/21, 16:27