65582[BUGFIX] Avoid using BackendWorkspaceRestriction
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php1+2 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+5 −5
- typo3/sysext/backend/Classes/Utility/BackendUtility.php3+3 −3
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php2+3 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+5 −11
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+2 −2
Review log 1419
-
Benni Mack uploaded patch set 1 09/05/20, 06:07
-
Benni Mack uploaded patch set 2 09/05/20, 06:10
-
TYPO3com voted on patch set 1 V -1 09/05/20, 06:19 Completed build in 11m 27s on Sat, 5 Sep, 06:19 AM Test Summary: 2 of 73691 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5251
-
TYPO3com voted on patch set 2 V -1 09/05/20, 06:24 Completed build in 14m 20s on Sat, 5 Sep, 06:24 AM Test Summary: 2 of 73691 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5252
-
Benni Mack uploaded patch set 3 09/05/20, 10:45
-
TYPO3com voted on patch set 3 V +1 09/05/20, 11:07 Completed build in 21m 42s on Sat, 5 Sep, 11:07 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5271
-
Andreas Kienast voted on patch set 3 CR +1 09/05/20, 11:16
-
Christian Kuhn commented on patch set 3 V +1 CR +1 09/22/20, 19:53
Overall, this patch is very hard to fully test and think through (manually). The fact that no test is affected shows us there is currently rather little coverage for instance for scenarios with multiple workspaces. However, the BackendWorkspaceRestriction is clearly broken. I found a couple of places in the backend that are actively fixed by the patch and I postulate the situation *should not get worse* but only better with the patch. Thus, I tend to +1 the patch. The places I tried to analyze in depth did result in an improvement.TranslationConfigurationProvider.php:136Unresolvedtested in FormEngine for userts options.additionalPreviewLanguages ... works (and yes, formEngine shows content from a different workspace without patch)BackendUtility.php:293UnresolvedThis fixes that both page modules show the workspace version of a translated page in live if a page has been changed in workspace. -
Christian Kuhn rebased onto patch set 4 09/22/20, 22:42
-
Christian Kuhn uploaded patch set 5 09/22/20, 22:46
-
Christian Kuhn commented on patch set 5 V +1 CR +1 09/22/20, 22:47
accidentially rebased ... -
TYPO3com voted on patch set 4 V +1 09/22/20, 23:01 Completed build in 19m 02s on Tue, 22 Sep, 11:01 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5832
-
TYPO3com commented on patch set 5 09/22/20, 23:10 Completed build in 18m 42s on Tue, 22 Sep, 11:10 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5835
-
Oli Bartsch voted on patch set 5 V +1 CR +1 09/23/20, 12:11
-
Benni Mack voted on patch set 5 V +2 CR +2 09/23/20, 12:25
-
Benni Mack merged patch set 6 09/23/20, 12:25
-
Markus Klein commented on patch set 6 10/03/20, 18:49
BackendUtility.php:293This one causes a regression for upgrades, see https://forge.typo3.org/issues/92464 -
Christian Kuhn commented on patch set 6 07/21/22, 12:57
DataMapProcessor.php:884regression https://forge.typo3.org/issues/97989 -
Benni Mack commented on patch set 6 08/19/22, 15:59
BackendUtility.php:293ReplyDoneDataMapProcessor.php:884ReplyDone