Review main Merged

65584[TASK] CSV integrity test script can fix fixtures

Christian Kuhn CR +2 V +2 Nightmare +1715 −1587 updated 09/05/20, 12:02

Commit message

CSV fixture files are a straight way to feed test database
with stuff and to assert database state after operations.
Script Build/Scripts/checkIntegrityCsvFixtures.php tests those
files for integrity, making sure all lines have the same number
of columns. Maintaining the number of commas when fiddling with
functional tests however is annoying.

The patch adds options to checkIntegrityCsvFixtures.php:
* '--fix' simply fixes files with broken integrity
* '--fixAll' goes through all files and looks for details
  like superfluous comma.

While --fixAll is used once now to establish a good baseline
on all .csv fixtutre files, --fix can be used whenever the
integrity script mumbles about broken stuff:

Build/Scripts/checkIntegrityCsvFixtures.php --fix

It is also added to runTests.sh:

Build/Scripts/runTests.sh -s fixCsvFixtures

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 65

Show 45 more files

Review log 1317

  1. Christian Kuhn uploaded patch set 1 09/05/20, 09:10

  2. TYPO3com voted on patch set 1 V -1 09/05/20, 09:10 Completed build in 24s on Sat, 5 Sep, 09:10 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5260

  3. Christian Kuhn uploaded patch set 2 09/05/20, 09:12

  4. TYPO3com voted on patch set 2 V +1 09/05/20, 09:25 Completed build in 12m 47s on Sat, 5 Sep, 09:25 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5261

  5. Christian Kuhn updated the commit message in patch set 3 09/05/20, 09:45

  6. Benni Mack voted on patch set 3 V +1 CR +1 09/05/20, 09:51

  7. Andreas Kienast voted on patch set 3 V +2 CR +2 09/05/20, 09:54

  8. Christian Kuhn commented on patch set 3 CR -1 09/05/20, 09:54

    let's bring the conflicting patch in, first ... it's more annoying to fix conflicts in the other patch, then here.
  9. Andreas Kienast commented on patch set 3 V 0 CR -2 09/05/20, 10:01

    What lolli said...
  10. TYPO3com voted on patch set 3 V +1 09/05/20, 10:06 Completed build in 20m 51s on Sat, 5 Sep, 10:06 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5263

  11. Andreas Kienast voted on patch set 3 CR 0 09/05/20, 11:41

  12. Christian Kuhn uploaded patch set 4 09/05/20, 11:44

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 09/05/20, 11:56

  14. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/05/20, 12:00

  15. Benni Mack voted on patch set 4 V +2 CR +2 09/05/20, 12:00

  16. TYPO3com voted on patch set 4 V +1 09/05/20, 12:02 Completed build in 15m 59s on Sat, 5 Sep, 12:02 PM Test Summary: 73212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5275

  17. Christian Kuhn merged patch set 5 09/05/20, 12:02