Review main Merged

65585[TASK] Provide web server url configuration for acceptance tests

Alexander Nitsche CR +2 V +2 Normal +133 −10 updated 09/08/20, 16:43

Commit message

In order to run TYPO3 Core acceptance tests not only in the TYPO3 Core
own docker environment but in an arbitrary environment the web server
url of the testing environment should be configurable by the
environment variable "typo3TestingAcceptanceBaseUrl".

For example, having a LEMP stack with an Nginx web server available at
http://nginx:8080 you would set the variable
"typo3TestingAcceptanceBaseUrl=http://nginx:8080" in the environment
of the acceptance tests runner.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Simon Gilli +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1421

  1. Alexander Nitsche uploaded patch set 1 09/05/20, 09:58

  2. TYPO3com voted on patch set 1 V -1 09/05/20, 10:20 Completed build in 21m 49s on Sat, 5 Sep, 10:20 AM Test Summary: 90 of 73691 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5265

  3. Alexander Nitsche uploaded patch set 2 09/05/20, 11:11

  4. TYPO3com voted on patch set 2 V +1 09/05/20, 11:26 Completed build in 14m 38s on Sat, 5 Sep, 11:26 AM Test Summary: 73212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5273

  5. Alexander Nitsche updated the commit message in patch set 3 09/05/20, 12:03

  6. TYPO3com voted on patch set 3 V +1 09/05/20, 12:15 Completed build in 11m 52s on Sat, 5 Sep, 12:15 PM Test Summary: 73212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5276

  7. Simon Gilli commented on patch set 3 CR +1 09/06/20, 11:34

    Nice one! Wondering there wasn't more to change :)
  8. Alexander Nitsche uploaded patch set 4 09/06/20, 12:43

  9. TYPO3com voted on patch set 4 V -1 09/06/20, 12:43 Completed build in 26s on Sun, 6 Sep, 12:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5301

  10. Alexander Nitsche uploaded patch set 5 09/06/20, 13:34

  11. TYPO3com voted on patch set 5 V -1 09/06/20, 13:34 Completed build in 23s on Sun, 6 Sep, 01:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5304

  12. Alexander Nitsche uploaded patch set 6 09/06/20, 13:48

  13. TYPO3com voted on patch set 6 V +1 09/06/20, 13:59 Completed build in 11m 38s on Sun, 6 Sep, 01:59 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5306

  14. Alexander Nitsche uploaded patch set 7 09/06/20, 14:05

  15. TYPO3com voted on patch set 7 V +1 09/06/20, 14:17 Completed build in 11m 43s on Sun, 6 Sep, 02:17 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5307

  16. Simon Gilli commented on patch set 7 09/06/20, 16:57

    codeception.yml:20

    Is this still used after the introduction of the Config above?
  17. Alexander Nitsche commented on patch set 7 09/06/20, 17:07

    codeception.yml:20 Reply

    Yes. The params part of the configuration is used to bring in System Environment Variables into Codeception Configuration. The Config module is used to bring the Codeception Configuration into the Tests.
  18. Simon Gilli voted on patch set 7 CR +1 09/07/20, 09:57

  19. Christian Kuhn voted on patch set 7 V +1 CR +1 09/08/20, 12:11

  20. Anja Leichsenring voted on patch set 7 V +2 CR +2 09/08/20, 16:42

  21. Anja Leichsenring merged patch set 8 09/08/20, 16:43