65586[BUGFIX] Do not use page Permission class on non-page permissions
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1114
-
Benni Mack uploaded patch set 1 09/05/20, 10:37
-
Benni Mack updated the commit message in patch set 2 09/05/20, 10:39
-
Anja Leichsenring commented on patch set 2 09/05/20, 10:50
how about introducing constants here? The int values are not telling anything. -
TYPO3com voted on patch set 1 V +1 09/05/20, 10:57 Completed build in 19m 50s on Sat, 5 Sep, 10:57 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5269
-
TYPO3com voted on patch set 2 V +1 09/05/20, 11:00 Completed build in 15m 38s on Sat, 5 Sep, 11:00 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5270
-
Benni Mack commented on patch set 2 09/05/20, 11:24
> Patch Set 2: > > how about introducing constants here? The int values are not telling anything. in general, we could do so (also for all others like pages.l18n_cfg). but then we'd need to extend this patch, but this was actually just cleaning up a change from a previous change. -
Christian Kuhn voted on patch set 2 V +1 CR +1 09/05/20, 13:45
-
Tymoteusz Motylewski commented on patch set 2 CR -1 09/05/20, 19:53
BackendUserAuthentication.php:1535UnresolvedCan you introduce a method for this chec, to make it more verbose when reading? -
Alexander Schnitzler commented on patch set 2 09/05/20, 19:56
Maybe a stupid question but why not introduce a new BitSet class for this but revert to the former, direct bit operations? -
Benni Mack uploaded patch set 3 09/17/20, 07:41
-
TYPO3com voted on patch set 3 V +1 09/17/20, 07:53 Completed build in 12m 00s on Thu, 17 Sep, 07:53 AM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5653
-
Anja Leichsenring commented on patch set 3 V +1 CR +1 09/17/20, 18:58
way better, thanks a lot. -
Georg Ringer voted on patch set 3 V +2 CR +2 09/17/20, 19:05
-
Georg Ringer merged patch set 4 09/17/20, 19:05