Review main Merged

65586[BUGFIX] Do not use page Permission class on non-page permissions

Benni Mack CR +2 V +2 Normal +46 −6 updated 09/17/20, 19:05

Commit message

The database fields "be_users.options" ("Mount from groups") and
"be_users.workspace_perms" (Allow editing on live workspace) use
the Page Permission class for checks, which is semantically incorrect.

The patch adapts the according changes in BackendUserAuthentication.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1114

  1. Benni Mack uploaded patch set 1 09/05/20, 10:37

  2. Benni Mack updated the commit message in patch set 2 09/05/20, 10:39

  3. Anja Leichsenring commented on patch set 2 09/05/20, 10:50

    how about introducing constants here? The int values are not telling anything.
  4. TYPO3com voted on patch set 1 V +1 09/05/20, 10:57 Completed build in 19m 50s on Sat, 5 Sep, 10:57 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5269

  5. TYPO3com voted on patch set 2 V +1 09/05/20, 11:00 Completed build in 15m 38s on Sat, 5 Sep, 11:00 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5270

  6. Benni Mack commented on patch set 2 09/05/20, 11:24

    > Patch Set 2: > > how about introducing constants here? The int values are not telling anything. in general, we could do so (also for all others like pages.l18n_cfg). but then we'd need to extend this patch, but this was actually just cleaning up a change from a previous change.
  7. Christian Kuhn voted on patch set 2 V +1 CR +1 09/05/20, 13:45

  8. Tymoteusz Motylewski commented on patch set 2 CR -1 09/05/20, 19:53

    BackendUserAuthentication.php:1535 Unresolved

    Can you introduce a method for this chec, to make it more verbose when reading?
  9. Alexander Schnitzler commented on patch set 2 09/05/20, 19:56

    Maybe a stupid question but why not introduce a new BitSet class for this but revert to the former, direct bit operations?
  10. Benni Mack uploaded patch set 3 09/17/20, 07:41

  11. TYPO3com voted on patch set 3 V +1 09/17/20, 07:53 Completed build in 12m 00s on Thu, 17 Sep, 07:53 AM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5653

  12. Anja Leichsenring commented on patch set 3 V +1 CR +1 09/17/20, 18:58

    way better, thanks a lot.
  13. Georg Ringer voted on patch set 3 V +2 CR +2 09/17/20, 19:05

  14. Georg Ringer merged patch set 4 09/17/20, 19:05