Review main Merged Breaking

65587[!!!][TASK] Do not create new version placeholders in workspaces anymore

Benni Mack CR +2 V +2 Nightmare +2100 −1927 updated 11/12/20, 09:46

Commit message

Creating a new record in a workspace adds two database rows.

One that is the "placeholder", which - since v10.4 - contains
the same metadata as the other record:

* t3ver_wsid = workspaceID
* t3ver_oid = 0 (simulating behavior of an "online pendant record")
* t3ver_state = 1

And the "versionized" record, identified by:

* t3ver_wsid = workspaceID
* t3ver_oid = uid of the new placeholder record
* t3ver_state = -1

As of TYPO3 v10, the first record is not needed anymore,
the versioned record can be queried directly, however, since
the relations (except MM) point to the placeholder record,
this one is kept.

As result, only one record is created from now on:

* t3ver_wsid = workspaceID
* t3ver_oid = 0 (no online counterpart)
* t3ver_state = 1

On reading, the record is queried directly (no overlay needed anymore!)
with the existing Database Doctrine Restrictions. On publishing, the
record just gets the state/stage/wsid set and is "live".

This brings fundamental benefits:

* No overlays needed when querying
* Fewer database records (placeholders are not helpful)
* Conceptual problems with placeholder and shadowed fields are removed

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 223

Show 203 more files

Review log 85155

Show 68130 earlier messages
  1. Benni Mack uploaded patch set 1 09/05/20, 11:41

  2. TYPO3com voted on patch set 1 V -1 09/05/20, 11:55 Completed build in 13m 17s on Sat, 5 Sep, 11:55 AM Test Summary: 683 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5274

  3. Benni Mack uploaded patch set 2 09/05/20, 13:24

  4. TYPO3com voted on patch set 2 V -1 09/05/20, 13:35 Completed build in 10m 28s on Sat, 5 Sep, 01:35 PM Test Summary: 674 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5281

  5. Benni Mack uploaded patch set 3 09/05/20, 13:46

  6. TYPO3com voted on patch set 3 V -1 09/05/20, 13:58 Completed build in 11m 13s on Sat, 5 Sep, 01:58 PM Test Summary: 668 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5282

  7. Benni Mack uploaded patch set 4 09/05/20, 15:11

  8. TYPO3com voted on patch set 4 V -1 09/05/20, 15:23 Completed build in 11m 33s on Sat, 5 Sep, 03:23 PM Test Summary: 603 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5284

  9. Benni Mack uploaded patch set 5 09/05/20, 15:37

  10. Benni Mack uploaded patch set 6 09/05/20, 15:48

  11. TYPO3com voted on patch set 5 V -1 09/05/20, 15:49 Completed build in 11m 07s on Sat, 5 Sep, 03:49 PM Test Summary: 603 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5286

  12. TYPO3com voted on patch set 6 V -1 09/05/20, 16:00 Completed build in 11m 03s on Sat, 5 Sep, 04:00 PM Test Summary: 603 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5287

  13. Benni Mack uploaded patch set 7 09/05/20, 21:28

  14. Benni Mack uploaded patch set 8 09/05/20, 21:44

  15. TYPO3com voted on patch set 8 V -1 09/05/20, 21:45 Completed build in 43s on Sat, 5 Sep, 09:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5289

  16. Benni Mack uploaded patch set 9 09/05/20, 21:45

  17. TYPO3com voted on patch set 7 V -1 09/05/20, 21:49 Completed build in 20m 26s on Sat, 5 Sep, 09:49 PM Test Summary: 591 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5288

  18. TYPO3com voted on patch set 9 V -1 09/05/20, 22:02 Completed build in 16m 22s on Sat, 5 Sep, 10:02 PM Test Summary: 585 of 73685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5290

  19. Benni Mack uploaded patch set 10 09/07/20, 21:08

  20. TYPO3com voted on patch set 10 V -1 09/07/20, 21:26 Completed build in 17m 51s on Mon, 7 Sep, 09:26 PM Test Summary: 585 of 73700 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5352

  21. Benni Mack uploaded patch set 11 09/10/20, 08:57

  22. Benni Mack uploaded patch set 12 09/30/20, 22:02

  23. TYPO3com voted on patch set 12 V -1 09/30/20, 22:29 Completed build in 24m 26s on Wed, 30 Sep, 10:29 PM Test Summary: 1939 of 74163 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6109

  24. Benni Mack uploaded patch set 13 10/02/20, 14:27

  25. TYPO3com voted on patch set 13 V -1 10/02/20, 14:54 Completed build in 23s on Fri, 2 Oct, 02:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6196

  26. Benni Mack uploaded patch set 14 10/12/20, 18:56

  27. TYPO3com voted on patch set 14 V -1 10/12/20, 19:10 Completed build in 13m 47s on Mon, 12 Oct, 07:10 PM Test Summary: 483 of 71377 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6459

  28. Benni Mack uploaded patch set 15 10/12/20, 19:38

  29. TYPO3com voted on patch set 15 V -1 10/12/20, 20:14 Completed build in 35m 22s on Mon, 12 Oct, 08:14 PM Test Summary: 280 of 69974 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6460

  30. Benni Mack uploaded patch set 16 10/12/20, 20:19

  31. TYPO3com voted on patch set 16 V -1 10/12/20, 20:55 Completed build in 34m 59s on Mon, 12 Oct, 08:54 PM Test Summary: 256 of 69950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6461

  32. Benni Mack rebased onto patch set 17 10/13/20, 14:02

  33. TYPO3com voted on patch set 17 V -1 10/13/20, 15:11 Completed build in 1h 09m 14s on Tue, 13 Oct, 03:11 PM Test Summary: 256 of 69950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6477

  34. Benni Mack rebased onto patch set 18 10/13/20, 16:01

  35. TYPO3com commented on patch set 17 10/13/20, 16:38 Completed build in 3h 45m 01s on Tue, 13 Oct, 04:38 PM Test Summary: 256 of 69950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6477

  36. TYPO3com voted on patch set 18 V -1 10/13/20, 17:06 Completed build in 1h 05m 00s on Tue, 13 Oct, 05:06 PM Test Summary: 218 of 69598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6484

  37. Benni Mack uploaded patch set 19 10/13/20, 19:44

  38. TYPO3com voted on patch set 19 V -1 10/13/20, 20:47 Completed build in 1h 03m 04s on Tue, 13 Oct, 08:47 PM Test Summary: 250 of 69939 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6504

  39. Benni Mack uploaded patch set 20 10/14/20, 08:50

  40. Benni Mack uploaded patch set 21 10/14/20, 08:51

  41. Benni Mack uploaded patch set 22 10/14/20, 08:54

  42. Benni Mack uploaded patch set 23 10/14/20, 09:26

  43. TYPO3com voted on patch set 21 V -1 10/14/20, 10:11 Completed build in 1h 20m 04s on Wed, 14 Oct, 10:11 AM Test Summary: 252 of 69950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6518

  44. TYPO3com voted on patch set 20 V -1 10/14/20, 10:12 Completed build in 1h 21m 18s on Wed, 14 Oct, 10:12 AM Test Summary: 252 of 69950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6517

  45. TYPO3com voted on patch set 22 V -1 10/14/20, 10:16 Completed build in 1h 15m 43s on Wed, 14 Oct, 10:16 AM Test Summary: 297 of 69490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6519

  46. TYPO3com voted on patch set 23 V -1 10/14/20, 10:37 Completed build in 1h 07m 58s on Wed, 14 Oct, 10:37 AM Test Summary: 279 of 69913 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6523

  47. TYPO3com commented on patch set 23 10/14/20, 20:42 Completed build in 12h 20m 52s on Wed, 14 Oct, 08:42 PM Test Summary: 252 of 69956 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6523

  48. Benni Mack uploaded patch set 24 10/15/20, 12:48

  49. TYPO3com voted on patch set 24 V -1 10/15/20, 13:53 Completed build in 1h 04m 38s on Thu, 15 Oct, 01:53 PM Test Summary: 252 of 69944 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6558

  50. Benni Mack uploaded patch set 25 10/19/20, 18:16

  51. Benni Mack uploaded patch set 26 10/19/20, 18:33

  52. Benni Mack uploaded patch set 27 10/19/20, 18:59

  53. TYPO3com voted on patch set 25 V -1 10/19/20, 19:26 Completed build in 1h 08m 03s on Mon, 19 Oct, 07:26 PM Test Summary: 224 of 68267 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6663

  54. TYPO3com voted on patch set 26 V -1 10/19/20, 19:39 Completed build in 1h 05m 53s on Mon, 19 Oct, 07:39 PM Test Summary: 224 of 68267 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6664

  55. Benni Mack uploaded patch set 28 10/19/20, 20:04

  56. TYPO3com voted on patch set 27 V -1 10/19/20, 20:11 Completed build in 1h 09m 51s on Mon, 19 Oct, 08:11 PM Test Summary: 224 of 68267 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6666

  57. TYPO3com voted on patch set 28 V -1 10/19/20, 21:15 Completed build in 1h 10m 16s on Mon, 19 Oct, 09:15 PM Test Summary: 170 of 67536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6669

  58. Benni Mack uploaded patch set 29 10/20/20, 08:45

  59. TYPO3com voted on patch set 29 V -1 10/20/20, 09:49 Completed build in 1h 03m 48s on Tue, 20 Oct, 09:49 AM Test Summary: 227 of 67914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6680

  60. Benni Mack uploaded patch set 30 10/27/20, 08:53

  61. TYPO3com voted on patch set 30 V -1 10/27/20, 09:45 Completed build in 51m 40s on Tue, 27 Oct, 09:45 AM Test Summary: 230 of 67995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6901

  62. Benni Mack uploaded patch set 31 10/28/20, 20:58

  63. TYPO3com voted on patch set 31 V -1 10/28/20, 22:04 Completed build in 1h 05m 11s on Wed, 28 Oct, 10:04 PM Test Summary: 230 of 67995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6980

  64. Benni Mack uploaded patch set 32 10/28/20, 22:08

  65. TYPO3com voted on patch set 32 V -1 10/28/20, 23:12 Completed build in 1h 03m 38s on Wed, 28 Oct, 11:12 PM Test Summary: 181 of 67995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6983

  66. Benni Mack uploaded patch set 33 10/29/20, 11:02

  67. TYPO3com voted on patch set 33 V -1 10/29/20, 12:05 Completed build in 1h 02m 27s on Thu, 29 Oct, 12:05 PM Test Summary: 181 of 67454 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6996

  68. Benni Mack uploaded patch set 34 10/29/20, 13:20

  69. TYPO3com voted on patch set 34 V -1 10/29/20, 14:15 Completed build in 54m 41s on Thu, 29 Oct, 02:15 PM Test Summary: 46 of 64930 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7002

  70. Benni Mack uploaded patch set 35 10/29/20, 14:19

  71. TYPO3com voted on patch set 35 V -1 10/29/20, 15:03 Completed build in 43m 19s on Thu, 29 Oct, 03:03 PM Test Summary: 118 of 67989 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7008

  72. Benni Mack uploaded patch set 36 10/29/20, 15:25

  73. TYPO3com voted on patch set 36 V -1 10/29/20, 15:37 Completed build in 11m 17s on Thu, 29 Oct, 03:37 PM Test Summary: 315 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7009

  74. Benni Mack uploaded patch set 37 10/29/20, 15:44

  75. Benni Mack uploaded patch set 38 10/29/20, 15:54

  76. TYPO3com voted on patch set 37 V -1 10/29/20, 15:57 Completed build in 13m 10s on Thu, 29 Oct, 03:57 PM Test Summary: 306 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7010

  77. TYPO3com voted on patch set 38 V -1 10/29/20, 16:07 Completed build in 13m 19s on Thu, 29 Oct, 04:07 PM Test Summary: 282 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7011

  78. Benni Mack uploaded patch set 39 10/29/20, 16:15

  79. TYPO3com voted on patch set 39 V -1 10/29/20, 16:27 Completed build in 11m 31s on Thu, 29 Oct, 04:27 PM Test Summary: 243 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7012

  80. Benni Mack uploaded patch set 40 10/29/20, 16:32

  81. TYPO3com voted on patch set 40 V -1 10/29/20, 16:44 Completed build in 12m 12s on Thu, 29 Oct, 04:44 PM Test Summary: 210 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7013

  82. Benni Mack uploaded patch set 41 10/29/20, 16:50

  83. TYPO3com voted on patch set 41 V -1 10/29/20, 17:06 Completed build in 16m 14s on Thu, 29 Oct, 05:06 PM Test Summary: 150 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7015

  84. Benni Mack uploaded patch set 42 10/29/20, 21:38

  85. TYPO3com voted on patch set 42 V -1 10/29/20, 21:59 Completed build in 20m 41s on Thu, 29 Oct, 09:59 PM Test Summary: 84 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7018

  86. Benni Mack uploaded patch set 43 10/30/20, 10:07

  87. TYPO3com voted on patch set 43 V -1 10/30/20, 10:19 Completed build in 11m 30s on Fri, 30 Oct, 10:19 AM Test Summary: 36 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7028

  88. Benni Mack uploaded patch set 44 10/30/20, 10:28

  89. TYPO3com voted on patch set 44 V -1 10/30/20, 10:41 Completed build in 12m 53s on Fri, 30 Oct, 10:41 AM Test Summary: 33 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7029

  90. Benni Mack uploaded patch set 45 10/30/20, 13:14

  91. TYPO3com voted on patch set 45 V -1 10/30/20, 13:26 Completed build in 11m 59s on Fri, 30 Oct, 01:26 PM Test Summary: 15 of 74012 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7031

  92. Benni Mack uploaded patch set 46 10/30/20, 13:43

  93. TYPO3com voted on patch set 46 V -1 10/30/20, 13:55 Completed build in 11m 42s on Fri, 30 Oct, 01:55 PM Test Summary: 12 of 74012 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7034

  94. Benni Mack uploaded patch set 47 11/03/20, 16:56

  95. TYPO3com voted on patch set 47 V -1 11/03/20, 17:09 Completed build in 13m 05s on Tue, 3 Nov, 05:09 PM Test Summary: 4 of 74024 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7095

  96. TYPO3com commented on patch set 47 11/03/20, 19:12 Completed build in 2h 28m 57s on Tue, 3 Nov, 07:12 PM Test Summary: 3 of 74024 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7095

  97. Benni Mack uploaded patch set 48 11/03/20, 20:13

  98. TYPO3com voted on patch set 48 V -1 11/03/20, 20:29 Completed build in 16m 30s on Tue, 3 Nov, 08:29 PM Test Summary: 3 of 74040 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7099

  99. Benni Mack uploaded patch set 49 11/04/20, 12:03

  100. TYPO3com voted on patch set 49 V +1 11/04/20, 12:15 Completed build in 12m 18s on Wed, 4 Nov, 12:15 PM Test Summary: 73555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7111

  101. Benni Mack uploaded patch set 50 11/07/20, 14:10

  102. TYPO3com voted on patch set 50 V +1 11/07/20, 14:23 Completed build in 13m 13s on Sat, 7 Nov, 02:23 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7170

  103. Christian Kuhn commented on patch set 50 CR -1 11/09/20, 14:21

    on it. temporary -1
  104. Christian Kuhn commented on patch set 50 11/10/20, 11:09

    DataHandler.php:3149

    This looks like a broken drive-by: $language >=0 means "default lang AND other langs but NOT "all languages". At the very least, this is not in-sync with the comment. Guess we should drop that change again for now?

    DataHandler.php:5184 Unresolved

    Great to see how this area melted with the two PH patches.

    DataHandler.php:5254 Unresolved

    Comment needs update

    PageSlugCandidateProvider.php:203

    not sure about impact here. let's talk about this one.

    RootlineUtility.php:251

    That's more a drive-by than a direct requirement of the ph removal, right? Frankly, I don't really understand why this is needed at all ...

    DataHandlerHook.php:562 Unresolved

    Not sure if i like the solution to branch out 'new record' and return afterwards with duplicating quite a bit of code in the child method. there is no more elegant way? Or should we have a refactoring round of that method in a dedicated patch?
  105. Christian Kuhn commented on patch set 50 11/10/20, 11:47

    createContentNCreateRelationNDiscardElement.csv:29 Unresolved

    better: # @todo: ref_index result is broken here. check flag is disabled in test.
  106. Christian Kuhn commented on patch set 50 11/10/20, 13:31

    rebasing now to see the state of the newly introduced functional tests.

    DataHandler.php:3149 Reply Unresolved

    Talk with benni: We'll try to drop that hunk again.

    PageSlugCandidateProvider.php:203 Reply Unresolved

    This change makes the method consider new-ph records now. This is ok, or at better than before.

    RootlineUtility.php:251 Reply Unresolved

    The workspace restriction prevents bugs here with multiple workspaces.
  107. Christian Kuhn rebased onto patch set 51 11/10/20, 13:32

  108. TYPO3com voted on patch set 51 V -1 11/10/20, 13:45 Completed build in 12m 39s on Tue, 10 Nov, 01:45 PM Test Summary: 10 of 74096 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7218

  109. Christian Kuhn uploaded patch set 52 11/10/20, 13:47

  110. TYPO3com voted on patch set 52 V +1 11/10/20, 14:00 Completed build in 12m 54s on Tue, 10 Nov, 02:00 PM Test Summary: 73611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7219

  111. Christian Kuhn uploaded patch set 53 11/10/20, 15:20

  112. TYPO3com voted on patch set 53 V -1 11/10/20, 15:21 Completed build in 36s on Tue, 10 Nov, 03:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7221

  113. Christian Kuhn uploaded patch set 54 11/10/20, 15:25

  114. TYPO3com voted on patch set 54 V -1 11/10/20, 15:37 Completed build in 12m 18s on Tue, 10 Nov, 03:37 PM Test Summary: 9 of 74105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7222

  115. Benni Mack uploaded patch set 55 11/10/20, 16:46

  116. Benni Mack uploaded patch set 56 11/10/20, 16:47

  117. TYPO3com voted on patch set 56 V -1 11/10/20, 17:05 Completed build in 16m 25s on Tue, 10 Nov, 05:05 PM Test Summary: 195 of 74105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7229

  118. TYPO3com voted on patch set 55 V -1 11/10/20, 17:08 Completed build in 19m 57s on Tue, 10 Nov, 05:08 PM Test Summary: 546 of 74105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7228

  119. Benni Mack uploaded patch set 57 11/11/20, 07:52

  120. TYPO3com voted on patch set 57 V -1 11/11/20, 08:04 Completed build in 12m 10s on Wed, 11 Nov, 08:04 AM Test Summary: 192 of 74105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7234

  121. Benni Mack uploaded patch set 58 11/11/20, 08:06

  122. TYPO3com voted on patch set 58 V -1 11/11/20, 08:20 Completed build in 13m 13s on Wed, 11 Nov, 08:20 AM Test Summary: 197 of 74105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7235

  123. Benni Mack uploaded patch set 59 11/11/20, 08:45

  124. Benni Mack uploaded patch set 60 11/11/20, 08:53

  125. TYPO3com voted on patch set 59 V -1 11/11/20, 08:56 Completed build in 11m 14s on Wed, 11 Nov, 08:56 AM Test Summary: 192 of 74105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7237

  126. Benni Mack commented on patch set 60 11/11/20, 08:59

    BackendUtility.php:3605 Unresolved

    (int) cast missing!
  127. TYPO3com voted on patch set 60 V -1 11/11/20, 09:04 Completed build in 11m 27s on Wed, 11 Nov, 09:04 AM Test Summary: 192 of 74105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7238

  128. Christian Kuhn commented on patch set 60 11/11/20, 12:06

    WorkspaceNewPlaceholderRemovalMigration.php:82 Unresolved

    this is / should be pointless. we can keep it for safety reasons, though.

    WorkspaceNewPlaceholderRemovalMigration.php:83 Unresolved

    this can be dropped for sure.

    WorkspaceNewPlaceholderRemovalMigration.php:85 Unresolved

    this will raise trouble if the -1 row comes in before the 1 row and the table has no soft delete ... guess we'll have to do the same logic here as above (find and update the 1 record here directly) to prevent that.
  129. Christian Kuhn commented on patch set 60 11/11/20, 12:15

    WorkspaceNewPlaceholderRemovalManyToManyImport.csv:35 Unresolved

    actually, that setup is stupid. last rows *should* be: ,29,300,"tt_content",0,1,"categories",,,,,,,,,,, ,30,300,"tt_content",0,2,"categories",,,,,,,,,,, ,28,302,"tt_content",0,1,"categories",,,,,,,,,,, ,29,302,"tt_content",0,2,"categories",,,,,,,,,,,
  130. Benni Mack uploaded patch set 61 11/11/20, 14:32

  1. Oli Bartsch commented on patch set 61 11/11/20, 14:38

    BackendUtility.php:3544

    Do we have to adjust this comment? (Affects multiple places)

    RootlineUtility.php:251

    is this related to the patch?

    WorkspaceNewPlaceholderRemovalMigration.php:26

    This needs some adaptions like NEW_VERSION_PLACEHOLDER (t3ver_state = -1), NEW_PLACEHOLDER (t3ver_state = 1), and so on. Maybe we should also change the class name to WorkspaceNewVersionPlaceholderRemovalMigration.

    DataHandlerHook.php:927

    Maybe use the constant here.
  2. TYPO3com voted on patch set 61 V +1 11/11/20, 14:44 Completed build in 11m 53s on Wed, 11 Nov, 02:44 PM Test Summary: 73620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7243

  3. Christian Kuhn commented on patch set 61 CR -1 11/11/20, 15:28

    will push soon.

    BackendUtility.php:3544 Reply

    Done

    RootlineUtility.php:251 Reply Unresolved

    Stumbled upon that one, too in my review. It's not strictly part of the patch. Talking with Benni, we decided to keep it here.

    WorkspaceNewPlaceholderRemovalMigration.php:26 Reply

    yeah.

    DataHandlerHook.php:927 Reply

    no. guess you mixed up _staGe and _staTe on reading ;)
  4. Christian Kuhn commented on patch set 61 11/11/20, 15:40

    WorkspaceNewPlaceholderRemovalMigration.php:26 Reply Unresolved

    I'd keep the class name, though ... should be good enough.
  5. Christian Kuhn commented on patch set 61 11/11/20, 15:40

    DataHandlerHook.php:927 Reply Unresolved

    Ah. StageService:: constants ... will do.
  6. Christian Kuhn uploaded patch set 62 11/11/20, 16:17

  7. TYPO3com voted on patch set 62 V +1 11/11/20, 16:30 Completed build in 12m 21s on Wed, 11 Nov, 04:30 PM Test Summary: 73620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7245

  8. Oli Bartsch uploaded patch set 63 11/11/20, 16:37

  9. Oli Bartsch uploaded patch set 64 11/11/20, 16:41

  10. TYPO3com voted on patch set 63 V -1 11/11/20, 16:51 Completed build in 13m 04s on Wed, 11 Nov, 04:51 PM Test Summary: 1 of 74105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7246

  11. TYPO3com voted on patch set 64 V +1 11/11/20, 16:56 Completed build in 14m 53s on Wed, 11 Nov, 04:56 PM Test Summary: 73620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7247

  12. Christian Kuhn uploaded patch set 65 11/11/20, 17:32

  13. TYPO3com voted on patch set 65 V +1 11/11/20, 17:46 Completed build in 13m 46s on Wed, 11 Nov, 05:46 PM Test Summary: 73620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7249

  14. Christian Kuhn uploaded patch set 66 11/11/20, 18:12

  15. Christian Kuhn uploaded patch set 67 11/11/20, 18:20

  16. Christian Kuhn commented on patch set 67 CR -1 11/11/20, 18:24

    oli will clean up the change in WorkspaceService a bit.
  17. TYPO3com voted on patch set 66 V +1 11/11/20, 18:26 Completed build in 13m 21s on Wed, 11 Nov, 06:26 PM Test Summary: 73620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7250

  18. TYPO3com voted on patch set 67 V +1 11/11/20, 18:37 Completed build in 14m 54s on Wed, 11 Nov, 06:37 PM Test Summary: 73620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7252

  19. Oli Bartsch uploaded patch set 68 11/11/20, 23:09

  20. TYPO3com voted on patch set 68 V +1 11/11/20, 23:24 Completed build in 14m 53s on Wed, 11 Nov, 11:24 PM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7262

  21. Oli Bartsch commented on patch set 68 V -1 11/11/20, 23:25

    Still something to verify
  22. Christian Kuhn voted on patch set 68 V +1 CR +1 11/12/20, 09:45

  23. Oli Bartsch commented on patch set 68 V +1 CR +1 11/12/20, 09:46

    > Patch Set 68: Verified-1 > > Still something to verify
  24. Benni Mack voted on patch set 68 V +2 CR +2 11/12/20, 09:46

  25. Benni Mack merged patch set 69 11/12/20, 09:46