Review 9.5 Merged

65589[TASK] CSV integrity test script can fix fixtures

Christian Kuhn CR +2 V +2 Expert +1007 −879 updated 09/05/20, 12:49

Commit message

CSV fixture files are a straight way to feed test database
with stuff and to assert database state after operations.
Script Build/Scripts/checkIntegrityCsvFixtures.php tests those
files for integrity, making sure all lines have the same number
of columns. Maintaining the number of commas when fiddling with
functional tests however is annoying.

The patch adds options to checkIntegrityCsvFixtures.php:
* '--fix' simply fixes files with broken integrity
* '--fixAll' goes through all files and looks for details
  like superfluous comma.

While --fixAll is used once now to establish a good baseline
on all .csv fixtutre files, --fix can be used whenever the
integrity script mumbles about broken stuff:

Build/Scripts/checkIntegrityCsvFixtures.php --fix

It is also added to runTests.sh:

Build/Scripts/runTests.sh -s fixCsvFixtures

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 66

Show 46 more files

Review log 34

  1. Christian Kuhn uploaded patch set 1 09/05/20, 12:36

  2. TYPO3com voted on patch set 1 V +1 09/05/20, 12:48 Completed build in 12m 24s on Sat, 5 Sep, 12:48 PM Test Summary: 75145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-773

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 09/05/20, 12:49

  4. Christian Kuhn merged patch set 2 09/05/20, 12:49