Review main Merged

65590[TASK] DatabaseRecordList SearchBox: Move html to fluid template

Daniel Windloff CR +2 V +2 Normal +67 −89 updated 09/08/20, 10:21

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Daniel Windloff uploaded patch set 1 09/06/20, 09:50

  2. TYPO3com voted on patch set 1 V -1 09/06/20, 09:50 Completed build in 23s on Sun, 6 Sep, 09:50 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5293

  3. Daniel Windloff uploaded patch set 2 09/06/20, 09:54

  4. TYPO3com voted on patch set 2 V +1 09/06/20, 10:05 Completed build in 10m 53s on Sun, 6 Sep, 10:05 AM Test Summary: 73212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5294

  5. Christian Kuhn commented on patch set 2 09/06/20, 12:24

    DatabaseRecordList.php:3759

    afaik, you need this line only if you use the 'short' f:translate syntax (not starting LLL:EXT...). I guess you don't use that in the template, so the line could be dropped? Imho, it's a hack anyway and should be dropped in core at all places where we use it ...
  6. Daniel Windloff uploaded patch set 3 09/06/20, 14:34

  7. Daniel Windloff commented on patch set 3 09/06/20, 14:36

    DatabaseRecordList.php:3759 Reply

    Done
  8. TYPO3com voted on patch set 3 V +1 09/06/20, 14:45 Completed build in 10m 50s on Sun, 6 Sep, 02:45 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5308

  9. Alexander Schnitzler commented on patch set 3 09/06/20, 15:59

    Search.html:2

    That's quite a heavy footprint for just changing the style here. Can't we use inline syntax here and have one div with all those classes?
  10. Daniel Windloff uploaded patch set 4 09/06/20, 18:14

  11. Daniel Windloff commented on patch set 4 09/06/20, 18:17

    Search.html:2 Reply

    Done
  12. TYPO3com voted on patch set 4 V +1 09/06/20, 18:25 Completed build in 11m 26s on Sun, 6 Sep, 06:25 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5309

  13. Jörg Bösche voted on patch set 4 V +1 CR +1 09/07/20, 07:06

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 09/08/20, 10:20

  15. Christian Kuhn merged patch set 5 09/08/20, 10:21