Review 10.4 Merged

65592[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:workspaces

Christian Kuhn CR +2 V +2 Normal +34 −28 updated 09/05/20, 13:00

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 45

  1. Christian Kuhn commented on patch set 1 09/05/20, 12:48

    Cherry Picked from branch master.
  2. Oliver Klee voted on patch set 1 CR +1 09/05/20, 12:55

  3. TYPO3com voted on patch set 1 V +1 09/05/20, 12:59 Completed build in 10m 43s on Sat, 5 Sep, 12:59 PM Test Summary: 74175 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-344

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 09/05/20, 13:00

  5. Christian Kuhn merged patch set 2 09/05/20, 13:00