Review 10.4 Merged

65594[BUGFIX] Don't call ResourceFactory::getStorageObject twice

Helmut Hummel CR +2 V +2 Easy +21 −7 updated 09/07/20, 07:50

Commit message

In http://review.typo3.org/11011 a plain DB call
that fetched the storage record was replaced with
usage of StorageRepository::findByUid, which in
turn calls ResourceFactory::getStorageObject again.

This leads to all events also called twice.

To avoid this a new internal method is introduced
on StorageRepository, which only fetches the storage
row again.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Helmut Hummel commented on patch set 1 09/06/20, 13:08

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/06/20, 13:20 Completed build in 11m 54s on Sun, 6 Sep, 01:20 PM Test Summary: 74175 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-346

  3. Helmut Hummel voted on patch set 1 V +2 CR +2 09/07/20, 07:50

  4. Helmut Hummel merged patch set 2 09/07/20, 07:50