Review 9.5 Merged

65596[BUGFIX] Correctly build query string without cHash

Helmut Hummel CR +2 V +2 Normal +89 −3 updated 09/07/20, 09:11

Commit message

For building URIs using the Symfony routing,
array URL arguments are deflated (foo[bar] -> foo__bar).

In case the final URI contains a remaining query string,
the arguments get inflated again. However the
query string of the URI is currently only updated, when
at least one of the remaining arguments require a cHash.

In case remaining arguments exist, the query string
needs to be always updated, whether the URI requires
a cHash or not.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 46

  1. Helmut Hummel commented on patch set 1 09/06/20, 13:14

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/06/20, 13:29 Completed build in 15m 20s on Sun, 6 Sep, 01:29 PM Test Summary: 6 of 75760 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-774

  3. Helmut Hummel uploaded patch set 2 09/07/20, 07:48

  4. TYPO3com voted on patch set 2 V +1 09/07/20, 08:01 Completed build in 12m 40s on Mon, 7 Sep, 08:01 AM Test Summary: 75160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-775

  5. Helmut Hummel voted on patch set 2 V +2 CR +2 09/07/20, 09:11

  6. Helmut Hummel merged patch set 3 09/07/20, 09:11