Review 10.4 Merged

65598[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:install

Benni Mack CR +2 V +2 Normal +65 −52 updated 09/07/20, 09:47

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 45

  1. Benni Mack commented on patch set 1 09/07/20, 09:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/07/20, 09:39 Completed build in 11m 47s on Mon, 7 Sep, 09:39 AM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-351

  3. Oliver Klee voted on patch set 1 CR +1 09/07/20, 09:40

  4. Benni Mack voted on patch set 1 V +2 CR +2 09/07/20, 09:47

  5. Benni Mack merged patch set 2 09/07/20, 09:47