65598[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:install
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- TYPO3com +1 CI
Issues 1
Files 18
- typo3/sysext/install/Classes/Command/LanguagePackCommand.php+2 −2
- typo3/sysext/install/Classes/Command/UpgradeWizardRunCommand.php+1 −0
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+4 −4
- typo3/sysext/install/Classes/Controller/UpgradeController.php+10 −8
- typo3/sysext/install/Classes/FolderStructure/AbstractNode.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/FileNode.php+1 −1
- typo3/sysext/install/Classes/Service/Session/FileSessionHandler.php+2 −2
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+1 −1
- typo3/sysext/install/Classes/Service/EnableFileService.php+4 −2
- typo3/sysext/install/Classes/Service/SessionService.php+2 −2
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+10 −5
- typo3/sysext/install/Classes/SystemEnvironment/ServerResponse/ServerResponseCheck.php+4 −4
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+8 −7
- typo3/sysext/install/Classes/SystemEnvironment/SetupCheck.php+2 −2
- typo3/sysext/install/Classes/Updates/DatabaseRowsUpdateWizard.php+1 −0
- typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php+8 −7
- typo3/sysext/install/Classes/ViewHelpers/Uri/ActionViewHelper.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+3 −3
Review log 45
-
Benni Mack commented on patch set 1 09/07/20, 09:27
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V +1 09/07/20, 09:39 Completed build in 11m 47s on Mon, 7 Sep, 09:39 AM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-351
-
Oliver Klee voted on patch set 1 CR +1 09/07/20, 09:40
-
Benni Mack voted on patch set 1 V +2 CR +2 09/07/20, 09:47
-
Benni Mack merged patch set 2 09/07/20, 09:47