Review 10.4 Merged

65601[BUGFIX] Add support for symfony/event-dispatcher-contracts v1

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 09/08/20, 14:22

Commit message

With the introduction of symfony/event-dispatcher-contracts
in https://git.typo3.org/Packages/TYPO3.CMS.git/commit/e4a1ae8762ee99712e4e5c9c2f8a3876bce97620

this change forced support for symfony5 in composer-based installations
(although non-composer-based installations use symfony5 bundled already),
as contracts v2 is only compatible with symfony v5, but contracts
v1 is used for symfony4.

This change allows composer-based installations to support both
versions (v5/v4) again, so extensions like EXT:solr (which requires
a package called solarium) to work with the dependency constraints
of TYPO3 Core.

- composer require "symfony/event-dispatcher-contracts:^1.1 || ^2.0" --no-update \
    --working-dir=typo3/sysext/core
- composer require "symfony/event-dispatcher-contracts:^1.1 || ^2.0" --no-update
- composer update --lock

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 46

  1. Benjamin Franzke commented on patch set 1 09/08/20, 14:00

    Cherry Picked from branch master. The following files contain Git conflicts: * composer.lock
  2. TYPO3com voted on patch set 1 V -1 09/08/20, 14:00 Completed build in 16s on Tue, 8 Sep, 02:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-368

  3. Benjamin Franzke uploaded patch set 2 09/08/20, 14:08

  4. TYPO3com voted on patch set 2 V +1 09/08/20, 14:20 Completed build in 12m 06s on Tue, 8 Sep, 02:20 PM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-369

  5. Benjamin Franzke commented on patch set 2 V +2 CR +2 09/08/20, 14:21

    This change is ready for review.
  6. Benjamin Franzke merged patch set 3 09/08/20, 14:22