Review 10.4 Merged

65602[TASK] Provide web server url configuration for acceptance tests

Anja Leichsenring CR +2 V +2 Normal +133 −10 updated 09/08/20, 17:03

Commit message

In order to run TYPO3 Core acceptance tests not only in the TYPO3 Core
own docker environment but in an arbitrary environment the web server
url of the testing environment should be configurable by the
environment variable "typo3TestingAcceptanceBaseUrl".

For example, having a LEMP stack with an Nginx web server available at
http://nginx:8080 you would set the variable
"typo3TestingAcceptanceBaseUrl=http://nginx:8080" in the environment
of the acceptance tests runner.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 34

  1. Anja Leichsenring commented on patch set 1 09/08/20, 16:43

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/08/20, 16:54 Completed build in 11m 15s on Tue, 8 Sep, 04:54 PM Test Summary: 74189 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-370

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/08/20, 17:03

  4. Anja Leichsenring merged patch set 2 09/08/20, 17:03