Review 10.4 Merged

65607[BUGFIX] Revert "[BUGFIX] Add support for symfony/event-dispatcher-contracts v1"

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 09/09/20, 11:29

Commit message

This reverts commit 75e742b70d78e307c088f4105faabad06f7ac31b.

Our Event dispatcher adapter is currently not compatible with
symfony/event-dispatcher-contracts:v1 (type declaration mismatch)
and therefore results in a runtime fatal error with symfony v4.

Compatibility with symfony v4 will be added in a new
revision of the reverted patch.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 47

  1. Benjamin Franzke commented on patch set 1 09/09/20, 10:54

    Cherry Picked from branch master. The following files contain Git conflicts: * composer.lock
  2. TYPO3com voted on patch set 1 V -1 09/09/20, 10:54 Completed build in 35s on Wed, 9 Sep, 10:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-377

  3. Benjamin Franzke uploaded patch set 2 09/09/20, 10:57

  4. TYPO3com voted on patch set 2 V -1 09/09/20, 11:09 Completed build in 11m 42s on Wed, 9 Sep, 11:09 AM Test Summary: 1 of 74675 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-378

  5. TYPO3com voted on patch set 2 V +1 09/09/20, 11:24 Completed build in 10m 59s on Wed, 9 Sep, 11:24 AM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-379

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/09/20, 11:29

  7. Benjamin Franzke merged patch set 3 09/09/20, 11:29