Review 10.4 Merged

65609[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Configuration

Daniel Goerz CR +2 V +2 Easy +4 −4 updated 09/10/20, 14:56

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 56

  1. Daniel Goerz commented on patch set 1 09/10/20, 09:42

    Cherry Picked from branch master.
  2. Jörg Bösche voted on patch set 1 V +1 CR +1 09/10/20, 13:31

  3. TYPO3com voted on patch set 1 V +1 09/10/20, 14:49 Completed build in 12m 03s on Thu, 10 Sep, 02:49 PM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-386

  4. Oliver Klee voted on patch set 1 CR +1 09/10/20, 14:50

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 09/10/20, 14:56

  6. Daniel Goerz merged patch set 2 09/10/20, 14:56