Review 10.4 Merged

65610[BUGFIX] Make external link checking more robust

Benni Mack CR +2 V +2 Easy +20 −4 updated 09/11/20, 08:12

Commit message

Previously, some URLs could result in errors which were not caught and
caused the link checking task to abort.

ExternalLinktype::preprocessUrl() now returns original URL in case
of any error, catches errors and exception and does some sanity
checking of parsed URLs before using the results.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 09/11/20, 06:36

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/11/20, 06:48 Completed build in 11m 45s on Fri, 11 Sep, 06:48 AM Test Summary: 74202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-387

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/11/20, 08:12

  4. Benni Mack merged patch set 2 09/11/20, 08:12